Re: Input Device Key Mapping (driver authoring advice?)

[Micah F. G. <mfg...@uw...>]

On Wed, 2005-06-07 at 15:55 +0200, Vojtech Pavlik wrote:
[snip]
> >=20
> > I used my best judgement when assigning keys, since the text on the
> > device does not always match up with a key defined in input.h.  Here is
> > a list of the potentially ambiguous or incorrect mappings:
> >=20
> > Start->KEY_RED
> > Pictures->KEY_MEDIA
> > DVD Menu->KEY_MENU
> > SAP->KEY_AUDIO
> > Repeat->KEY_AGAIN
> > CC/Teletext->KEY_SUBTITLE
> > Music->KEY_MP3
>=20
> The problem is that the markings on the device aren't important in case
> of the Consumer HID usage page. We need to follow the spec
> (http://www.usb.org/developers/devclass_docs/Hut1_11.pdf).
>=20
> > Allow me to justify the silly ones.  The start key is big and red,
> > Google told me SAP stands for "Secondary Audio Program", and there is n=
o
> > key close to pictures/graphics/image.
>=20
> We can add KEY_* definitions, if they are likely to be used on other
> devices, too.

Well, I am satisfied with these mappings.  They make sense (to me) for
this device.  If you feel like adding keys for some of those buttons,
I'll change it to use them.

>=20
> > The patch failed on account of HID_UP_LOGIVENDOR not being defined.  I
> > fixed two hunks manually, so it should work fine with your tree,
> > Vojtech.
>=20
> Sorry for that, it's defined in an earlier patch I didn't send to you.
>=20
> > Thanks again for all your help.  Please keep me posted if something is
> > wrong.
>=20
> > --- gitandhidpatches/drivers/usb/input/hid-input.c	2005-07-05 18:29:32.=
726219000 -0400
> > +++ micah/drivers/usb/input/hid-input.c	2005-07-05 18:42:15.489888750 -=
0400
> > @@ -237,6 +237,7 @@
> >  				case 0x000: goto ignore;
> >  				case 0x034: map_key_clear(KEY_SLEEP);		break;
> >  				case 0x036: map_key_clear(BTN_MISC);		break;
> > +				case 0x045: map_key_clear(KEY_RADIO);		break;
>=20
> This is rather suspicious, considering what Consumer.0045 is supposed to
> mean. I can add it, but I expect it'll be incorrect for other devices.

I am the appropriate authority to make this decision.  Now that I look
at the spec, I see your point.  Its up to you, but in hindsight, I don't
see much point in breaking the specifications.  If you add a
KEY_MENU_RIGHT, I'll change it, if not, I wont.

> > -				case 0x209: map_key_clear(KEY_PROPS);		break;
> > +				case 0x209: map_key_clear(KEY_INFO);		break;
>=20
> See the spec on this one.

Yup, my bad.

Let me know what you want to do with ID 45 on the consumer page (and the
other buttons), and I'll resubmit.
--=20
Micah Galizia
mfg...@uw...

"The mark of an immature man is that he wants to die nobly for a cause,
while the mark of the mature man is that he wants to live humbly for
one."   --W. Stekel