From: Zoltan B. <zb...@fr...> - 2005-03-05 20:54:24
|
Hi, Aivil! Linux-2.6.11-mm1 is released, I updated your ruby-2.6.11-rc4-mm1-4.diff.bz2 for that. There were only small trivial rejects in vt.c, vt_ioctl.c and vt_kern.h. I made a test compilation for fbcon+radeonfb. It compiled without warnings for me except these: drivers/video/console/fbcon.c: In function `fbcon_switch': drivers/video/console/fbcon.c:1926: warning: unused variable `ops' drivers/video/console/fbcon.c:1885: warning: 'prev_console' might be=20 used uninitialized in this function drivers/video/console/fbcon.c: At top level: drivers/video/console/fbcon.c:374: warning: 'search_for_mapped_con'=20 defined but not used Looking at the code, the one about "prev_console" might be harmful. Does it work at all, or fbcon_switch isn't used? Also, did you create 'search_for_mapped_con'? It's not used anywhere. (Yet?) I haven't booted with it yet, the patch against 2.6.11-mm1 is attached. Don't you think that we should aim for inclusion into 2.6.11-mm2? Seriously, the patch is not intrusive and small enough, so we may not have to split it up. Andrew Morton may accept it as-is, although he (and others) definitely will have some comments. Best regards, Zolt=E1n B=F6sz=F6rm=E9nyi |