From: Aivils S. <Aiv...@un...> - 2003-11-15 08:10:42
|
> Presently the kbd_inline functions pass in a pointer for struct > kbd_struct. Then the inlines are called as follows: > > get_kbd_mode(&vc->kbd_table,.. > > I purpose that we go back > > get_kbd_mode(vc->kbd_table,... > > and the inline functions don't pass in a pointer anymore. Since it is a > inline function we don't have the cost of a stack push and pop. Why You never print set_kbd_mode(vc->kbd_table,... which actualy copy subject vc->kbd_table for usage _inside_ set_kbd_mode - do nothing _outside_ function body. Do You will use two types of agruments, get_kbd_mode(struct kbd_struct kbd, set_kbd_mode(struct kbd_struct *kbd, If You like performance, the You will eliminate find_vc() and use vc_cons, because anyway we have only one tty range 1-63, and so special vt->vc_cons[] is redundant. Aivils Stoss |