Re: dumbcon settings

[Svetoslav S. <ga...@st...>]

Quoting Svetoslav Slavtchev <ga...@st...>:

> Quoting Warren Bell <wa...@ob...>:
> 
> > Hello...
> > 
> > I've suddenly become frantically busy, so I apologise for my silence... 
> > 
> > To answer your MUCH earlier question - yes, another happy customer with
> > 3 pci NVIDIA cards and 1 AGP :)
> > 
> > I was just wondering... When I set dumbcon to a number higher than 6,
> > the kernel goes crazy and panics... Are you aware of this problem? Is
> > there a fix?
> 
> Hi ,
> 
> am, nice catch :)
>  IMO(but i might be of course wrong)
>  this is a bug and a missing feature,
> 
> the max number for dumbcon is 7 
> 
> 1.) bug because the code that parses the cmdline does allow to set a bigger
> number( it should limit to the maximum alowed)
> 
> 2.) and a feature (would be nice to have probably) to select the number of
> consoles per VT. currently it's hardcoded in include/linux/vt_kern.h 
> 
> MIN_NR_CONSOLES 1      /* must be at least 1 */
> MAX_NR_CONSOLES 63     /* serial lines start at 64 */
> MAX_NR_USER_CONSOLES 8 /* number of VCs per VT */
> 
> so (1VGA +7DUMB consoles) * 8 = MAX_NR_CONSOLES 
> 
> if you need more dumb consoles you should try lowering MAX_NR_USER_CONSOLES

and encrease "MAX_DUMB_CONSOLES" in drivers/video/dumbcon.c ,
which currently is 8
 
> or may be even better:
> 
> Aivils can you hack the code to alocate MIN_NR_CONSOLES for dumb consoles ?
> 
> and/or add a config option for MAX_NR_USER_CONSOLES ?
> 
> 
> best,
> 
> svetljo  
> 
> PS.
> Aivils are my assumptions correct ?
> can you also fix "the bug" 

Aivils, shouldn't dumbcon_setup() also check for dumb_num < MAX_DUMB_CONSOLES,
and in case it's bigger to use MAX_DUMB_CONSOLES ?

best,

svetljo