Re: /s/Drivers/Handlers in input proc interface

[Vojtech P. <vo...@su...>]

On Thu, Sep 12, 2002 at 05:26:51PM +1000, Brad Hards wrote:

> The proc interface for the input subsystem current provides entries like this 
> in /proc/bus/input/devices:
> 
> I: Bus=0003 Vendor=046d Product=c002 Version=0120
> N: Name="Logitech USB-PS/2 Mouse M-BA47"
> P: Phys=usb-00:01.2-2.2/input0
> D: Drivers=mouse0 event2
> B: EV=7
> B: KEY=f0000 0 0 0 0 0 0 0 0
> B: REL=103
> 
> I think that the D: line is wrong. Those aren't really drivers, they are the 
> handlers. Driver is a concept associated with the input_register_device() 
> call (so it'd be more like hid or atkbd or whatever).
> I guess knowing the drivers might be useful eventually, although you can 
> normally deduce it from a combination of the P: and N: lines.
> 
> The attached patch does the trivial relabelling. Please apply to your tree and 
> send to Linus if OK.
> 
> BTW: I thought about doing a Handler/Handlers test based on the number of 
> handlers, but that might make parsing the /proc entries harder. So not this 
> time.

Patch applied. I changed it to "H: Handlers" instead of "D: Handlers",
if we're changing it (and breaking potential software that parses it,
which is none at the moment), we should do it completely.

There is one more problem with "B:", and that is the numbers there are
longs, thus breaking 32-bit emulations on top of 64-bit kernels. This
needs to be fixed. I haven't found a nice way yet, though.

-- 
Vojtech Pavlik
SuSE Labs