Re: Event API changes - EVIOCGID

[Brad H. <bh...@bi...>]

On Tue, 23 Jul 2002 02:04, Vojtech Pavlik wrote:
> On Sun, Jul 21, 2002 at 08:50:56PM +1000, Brad Hards wrote:
> > G'day,
> >
> > The attached patch basically implements:
> > +struct input_devinfo {
> > +       uint16_t bustype;
> > +       uint16_t vendor;
> > +       uint16_t product;
> > +       uint16_t version;
> > +};
> > +
> >
> > -#define EVIOCGID               _IOR('E', 0x02, short[4])              
> > /* get device ID */ +#define EVIOCGID               _IOR('E', 0x02,
> > struct input_devinfo)   /* get device ID */
> >
> > It affects just about every input driver, as a result of some associated
> > cleanups that I applied, and its about 40K uncompressed - hence the gzip.
> >
> > Is there anything that would stop this being applied?
>
> No, the patch is OK.
I am not happy about the change from uint16_t to __u16, which you appear
to have made before sending this to Linus.

That is a broken change - there is a standard type, and you've changed
it to a non-standard type. This is confusing to userspace programmers, and
I cannot provide a satisfactory explaination for this in documentation.

Please change it back.

Brad

-- 
http://conf.linux.org.au. 22-25Jan2003. Perth, Australia. Birds in Black.