Re: Event API changes - EVIOCGID

[Vojtech P. <vo...@su...>]

On Sun, Jul 21, 2002 at 08:50:56PM +1000, Brad Hards wrote:

> G'day,
> 
> The attached patch basically implements:
> +struct input_devinfo {
> +       uint16_t bustype;
> +       uint16_t vendor;
> +       uint16_t product;
> +       uint16_t version;
> +};
> +
> 
> -#define EVIOCGID               _IOR('E', 0x02, short[4])               /* get device ID */
> +#define EVIOCGID               _IOR('E', 0x02, struct input_devinfo)   /* get device ID */
> 
> It affects just about every input driver, as a result of some associated
> cleanups that I applied, and its about 40K uncompressed - hence the gzip.
> 
> Is there anything that would stop this being applied?

No, the patch is OK.

> Also, I note that some drivers don't set all the id values (before or after 
> patch). Is there any reason for this?

That'd be a bug.

Now, if you could fix that, I'd be much happier applying the patch. ;)

-- 
Vojtech Pavlik
SuSE Labs