Re: [Linuxconsole-commit]CVS: ruby/linux/include/linux input.h,1.65,1.66

[Rodrigo D. <cu...@uo...>]

Johann Deneux wrote:

>>> The point is that input.h should include the header defining uint16_t.
>>>
>> I don't think so. The kernel routines using uint16_t should include 
>> the kernel header <linux/types.h>, while the userspace routines 
>> should use the standard header (<stdint.h>).
>>
>
> Perhaps a conditional include would do it ? I personally hate it when 
> headers depending on other headers don't handle these dependencies by 
> themselves, forcing the user to guess what could be the right thing to 
> include in order to use some header. 

        Me too...I'm not exactly sure what uint16_t would conflict with 
if it were defined outside the kernel, but the fact is that it is only 
defined within kernel code(see asm/types.h)...About being 
kernel-specific, the linux/input.h is kernel-dependant too, so I guess 
maybe it's ok to use __u16??
        How about making it more practical - will everything work if we 
leave __u16?? 'cause non-kernel programs(such as fftest.c) have trouble 
compiling with uint16_t...I don't see a reason not to leave it __u16 if 
it works fine...

Rodrigo

-- 
* Rodrigo Damazio
* cu...@uo.../rod...@po.../rda...@ls...
* ICQ: #3560450         Homepage: http://www.vros.com/cuddly/
* Engenharia da Computação / Laboratório de Sistemas Integráveis(LSI)
* Escola Politécnica - USP - São Paulo