Re: [Linuxconsole-commit]CVS: ruby/linux/include/linux input.h,1.65,1.66

[Johann D. <joh...@la...>]

Rodrigo Damazio wrote:
> Update of /cvsroot/linuxconsole/ruby/linux/include/linux
> In directory usw-pr-cvs1:/tmp/cvs-serv2684/linux/include/linux
> 
> Modified Files:
> 	input.h 
> Log Message:
> Fix for the types problem - uint16_t and similars are not exported outside the kernel.
> They were replaced by __u16 and similars. fftest and other utils should now compile OK.
> 

No, uint16_t is not a kernel specific thing. __u16 is. I prefered it the 
other way.

I switched from __u16 to uint16_t on the advice of Brad Hards. The point 
is that uint16_t is apparently a standard type (C99). __u16 is a 
linux-kernel specific thing (16 bit unsigned integer visible from user 
space).
The discussion went on on linux-usb, and apparently no agreement was 
reached.
The point is that input.h should include the header defining uint16_t. 
That would be a more proper fix.
I don't really care what we actually use. After all, an unsigned 16 bit 
int remains an unsigned 16 bit int whatever we call it. But we should 
settle this at once and make up our minds.

> 
> Index: input.h
> ===================================================================
> RCS file: /cvsroot/linuxconsole/ruby/linux/include/linux/input.h,v
> retrieving revision 1.65
> retrieving revision 1.66
> diff -u -d -r1.65 -r1.66
> --- input.h	15 Apr 2002 19:14:22 -0000	1.65
> +++ input.h	3 May 2002 18:47:12 -0000	1.66
> @@ -522,62 +522,62 @@
>   */
>  
>  struct ff_replay {
> -	uint16_t length; /* Duration of an effect in ms. All other times are also expressed in ms */
> -	uint16_t delay;  /* Time to wait before to start playing an effect */
> +	__u16 length; /* Duration of an effect in ms. All other times are also expressed in ms */
> +	__u16 delay;  /* Time to wait before to start playing an effect */
>  };
>  
> [And so on. Other undos of my earlier change]

-- 
Johann Deneux