Re: evdev types

[Johann D. <jo...@do...>]

Brad Hards wrote:
> On Tue, 23 Apr 2002 01:10, Vojtech Pavlik wrote:
> 
>>On Mon, Apr 22, 2002 at 06:40:25PM +1000, Brad Hards wrote:
>>
> <snip>
> 
>>>I can maybe do some patches for the input system for 2.4 if you just need
>>>grunt work.
>>>
>>It would be nice, if you could. I'm rather low on time right now (should
>>be better after a couple weeks), because of other projects (robotic cup,
>>wedding, ...).
>>
> Congratulations!
> 
> I am working on the patches.
> 
> I am trying for the following breakdown:
> Patch 1 - changes to 2.4.19-pre7 from CVS that are userspace visible (ie the 
> evdev ioctl's). I am doing it without my changes (and some equivalent changes 
> to the new "set global state" ioctls). I will send those when this set is 
> accepted.
> 
> Patch 2 - changes to 2.4.19-pre7 from CVS to implement the revised modular 
> system, including hotplug
> 
> Patch 3 - changes to 2.4.19-pre7 from CVS to implement /proc
> 
> Patch 4 - changes to 2.4.19-pre8 (or whatever patch the first three go into, 
> plus 1 non-rc)  from CVS for FF.
> 
> Patch 5 - minor changes (Vojtech's email address, Suse deletion, etc)
> 
> Patch 6 (in 2.4.20-pre, probably) to provide structures for ioctl argp's, as 
> appropriate, based on my prior set of patches.
> 
> Questions:
> 1. Johann - do you think the FF stuff is stable enough? I don't have any 
> device to try it yet, so I think that maybe I have to defer Patch 4 to you.
> 

You mean the API or the drivers ? The API looks ok, except for the 
rumble effects. There is a big chance that struct ff_rumble_effect 
changes. Other ff* stuff shouldn't move.
The I-Force driver is stable enough to be actually used in games. Other 
drivers (PID, Logitech) aren't yet functional.

I can take care of this patch.

> 2. I'm not planning to make patches for evbug, power or tsdev drivers into 2.4 
> at this stage. Does this seem reasonable to developers? Also, I'm leaving out 
> all the pm stuff - again, does this seem reasonable at this stage?
> 
> 3. In input.c:input_call_hotplug(), there is a KERN_ERR that says:
> "input.c: calling hotplug a hotplug agent defined\n"
> is that supposed to be:
> "input.c: calling hotplug without a hotplug agent defined\n" ?
> 
> 4, The patches will likely be fairly large  (circa 2000 lines). Do developers 
> want to see them posted to the list as well as sent to Vojtech for 
> onforwarding to Marcelo?

I don't mind receiving big mails, but I can't talk for everyone. Perhaps 
you could make them available by ftp or http and post the URL ?

-- 
Johann Deneux