Re: evdev types

[Vojtech P. <vo...@su...>]

On Mon, Apr 15, 2002 at 11:11:33PM +1000, Brad Hards wrote:
> On Mon, 15 Apr 2002 20:22, Brad Hards wrote:
> > On Mon, 15 Apr 2002 17:40, Vojtech Pavlik wrote:
> > <snip>
> >
> > > Feel free to submit a patch. :) I'll most likely accept it.
> >
> > OK. I'll attack this problem in small chunks.
> >
> > Patch against evtest.c and patch against 2.4.19-pre6 attached, just
> > attacking the EVIOCGID ioctl at this stage. Note that most of the kernel
> > changes are in driver/usb.

> Note: I missed a bit in the patch - should have incremented the version 
> (EV_VERSION). Please don't forward the patch without adding that part.

May I suggest one more change?

dev->dinfo.bustype to dev->id.bus
dev->devinfo.id_vendor ro dev->id.vendor

It's no less informative, and looks much better. 

-- 
Vojtech Pavlik
SuSE Labs