Re: input.h changes

[Johann D. <jo...@Do...>]

On Thu, 31 Jan 2002, Bj|rn Augustsson wrote:

> Quoting Johann Deneux <jo...@Do...>:
> > Hi,
> > 
> > I am changing the ff_effect struct. I went for the 1-parameter-1-effect
> > scheme (actually it's really (1,2)-parameter(s)-1-effect).
> 
> Good. 
> 
> >         __u16 right_saturation[2]; /* Max level when joystick is on the
> > right */
> >         __u16 left_saturation[2];  /* Max level when joystick in on the
> > left */
> > 
> >  [...]
> > Note the arrays. There is one value for each axis. The axis mumber has
> > become useless and has therefore been droped.
> 
> I wondered about this part when reading the spec. Why two axes? Why not
> 3? Or "n"?  This seems a bit joystick-centered, I can easily imagine a

Indeed. Then we would need a list of (parameter/axis id) pairs.
That sounds doable.

> spaceball-like device with FF in all 3 axis. (And rotation This seems a
> bit joystick-centered, I can easily imagine a spaceball-like device 
> with FF in all 3 axis. (And rotational around all as well)
> 
> Oh well.
> 
> >         struct ff_shape shape;
> 
> How would you feel about renaming shape to envelope? It fits the PID
> spec, and it has some precedent from audio waveforms.

Ok. I can also change the ff_interactive_effect to ff_condition_effect,
if you prefer.

>  
> > The _u32 for the number of samples is a bit oversized, maybe.
>  
> Well, 16 bits could be to small in some future, so I think we should go
> with 32.
>  
> Antother thing we might want to add to the API is supporting the "Start
> Solo" action on an effect, in addition to the "start" and "stop" that we

What do you mean ? One can only start one effect at a time ? Or do you
mean to play an effect to play once ? That's already supported.


-- 
Johann Deneux