From: Johann D. <jo...@Do...> - 2002-01-27 19:58:15
|
On Sun, 27 Jan 2002, Vojtech Pavlik wrote: > On Sat, Jan 26, 2002 at 11:55:51PM +0100, Bj|rn Augustsson wrote: > > > > How come you set the output interrupt pipe to be a bulk pipe? That seems > > obviously wrong, and it wasn't that way in my patch. > > I'll have to research this further, but for me it was the only working > way to generate an one-shot out interrupt. Actually it's the same on the > USB bus. But I agree that it's non-obvious and that there may be a > better way to do it. > > > Do you know something I don't? > > (It had a "/* FIXME should we use sndint here? */" after it, which was > > removed by 1.39) > > See above. You can try with the sndintpipe - if it works, OK. I can't > check with any HID device right now. Perhaps Johann Deneux can check > with I-Force - there is also bulk used instead of int and it works OK. I tried to replace: FILL_BULK_URB(&iforce->out, dev, usb_sndbulkpipe(dev, epout->bEndpointAddress), iforce + 1, 32, iforce_usb_out, iforce); by: FILL_INT_URB(&iforce->out, dev, usb_sndintpipe(dev, epout->bEndpointAddress), iforce + 1, 32, iforce_usb_out, iforce, 0); It did not work. Maybe there are other changes to do, but I do not see which ones. The last parameter should tell the driver to use one-shot out interrupts, which I guess is what we want. -- Johann Deneux |