From: James S. <jsi...@tr...> - 2001-11-14 17:57:16
|
> I think that it is much easier to create an > > int is_it_a_general_framebuffer_option(struct fb_info* fbi, > const char* option); > > and then in driver do: > > while ((this_opt = strsep(&options, ",")) != NULL) { > if (!*this_opt) continue; > if (is_it_a_general_framebuffer_option(fbi, this_opt)) continue; > if (strcmp(this_opt, "....")) ... > } > > In such case you have much better control over specified options > command line, you can parse some options in special way, you can > specify fbdev own defaults for fb_info fields, ... And you do not > have to change API. But I think that you all know my position very well. This is pretty close to what we have in CVS. Of course doing it this way means every framebuffer driver needs its own setup function. |