Re: Force feedback bugs

[Vojtech P. <vo...@su...>]

On Sat, Sep 29, 2001 at 02:03:11PM +0200, Johann Deneux wrote:
 
> I am not especially willing to make the distinction between effect packets
> and parameter packets visible to the user. Other protocoles may have a
> different understanding of what goes into an effect packet, and what goes
> into a parameter packet.
> What I could do is store the effects uploaded with ioctl in the
> driver. When other ioctls are performed to update an effect, I could
> analyse the difference and send only the necessary packets.
> Or I could change the API. Each call to ioctl would set one property of an
> effect:
> 
> struct effect_property prop;
> prop.type = FF_PROP_ATTACK_LEVEL;
> prop.value = ...
> ioctl(fd, EVIOCSFF, &prop);
> 
> prop.type = FF_PROP_ATTACK_DURATION;
> prop.value = ...
> ioctl(fd, EVIOCSFF, &prop);
> ...
> 
> Instead of the one big ff_effect structure used now.

I think the differential uploading is nicest.

-- 
Vojtech Pavlik
SuSE Labs