Re: init functions

[Petr V. <VAN...@vc...>]

On 29 Jun 01 at 13:17, Paul Mundt wrote:

> #ifdef MODULE
> module_init(myfb_init);
> #endif
> module_exit(myfb_exit);

...
 
>     for (i = 0; i < NUM_FB_DRIVERS; i++)
>         if (fb_drivers[i].init)
>             fb_drivers[i].init();
> 
> Now this is cute and all, but it's about as practical as using a bulldozer
> to hunt down small furry creatures.

And after applying your hack we either (a) call some initialization
twice or (b) cannot reorder framebuffers. If you do not know
what I'm talking about, try booting your kernel with

video=vga16: video=matrox:

and then

video=matrox: video=vga16:

and look at completely different behavior (of course if you have
at least matrox alone in the box; you can replace matrox/vga16 with
framebuffer drivers you use). As long as there is no
global kernel service to reorder device scanning (such as my kernel
has for PCI), it is unavoidable to have this hack. With SCSI you can
say that your main disk is /dev/sdq, but with framebuffers it is
really fatal if something wents wrong and you even do not see what
went wrong because of console is now on some videocard without attached
monitor, or on vfb...
                                        Best regards,
                                                Petr Vandrovec
                                                van...@vc...