From: Vojtech P. <vo...@su...> - 2000-08-22 11:21:38
|
On Tue, Aug 22, 2000 at 12:05:03PM +0200, Vojtech Pavlik wrote: > On Tue, Aug 22, 2000 at 11:43:26AM +0200, Vojtech Pavlik wrote: > > On Mon, Aug 21, 2000 at 08:43:37PM -0700, Linus Torvalds wrote: > > > > > On Tue, 22 Aug 2000, Vojtech Pavlik wrote: > > > > > > > > This one moves just the non-USB stuff of the input drivers out of > > > > drivers/usb. That is, the bus-independent userland interface (char > > > > device) modules. It places them in drivers/char. And modifies the > > > > Makefiles and Config.in's accordingly. > > > > > > I'd actually prefer drivers/input. > > > > > > The argument I had against drivers/input was not an argument against a new > > > subdirectory. It was an argument against moving the things like hid.c and > > > the like to drivers/input, like the email I replied to tried to do. > > > > > > hid.c is something USB-specific. It had better _not_ be a part of any > > > "generic input layer". The same is true of usbkbd.c and friends. They are > > > _usb_ drivers, and shall belong in drivers/usb. > > > > Ok. Here is a patch that does that. Any more objections? > > Replying to myself: This doesn't work. iforce.c (using both serial and > USB interfaces) doesn't get compiled in correctly when only serial > interface is selected. > > More work ahead. Done now. Please check this patch if it's OK. It moves iforce.c out of drivers/usb, but that's necessary. Anyway, iforce.c is more a joystick driver than an USB driver. -- Vojtech Pavlik SuSE Labs |