From: Vojtech P. <vo...@su...> - 2000-08-20 20:36:31
|
On Sun, Aug 20, 2000 at 03:43:23PM +0200, Franz Sirl wrote: > On Sun, 20 Aug 2000, jsi...@ne... wrote: > > > Any reason you don`t accept this patch? To me it looks like a obvious > > > and clean solution and it would greatly simplify my use of the input > > > infrastructure in my new driver for ADB input devices. Otherwise ugly > > > Config.in and Makefile hacks will be necessary to select this driver in > > > the drivers/usb directory if only CONFIG_ADB is set (same problem that > > > already happens to the people trying to use joysticks without CONFIG_USB > > > set). > > > If you have any reason to reject that change (which essentially is > > > just a move of files) for 2.4.0, please tell us. > > > > Yes it was rejected because of the massive moving of files. Linus feels > > that ugly Config.in and Makefile hacks will do for now. > > Hmm, did Linus reject privately? I didn't see anything on linux-kernel. > > Well, OK. This will get really ugly when adbhid.c gets added with one of the > next PPC merges and and drivers/usb has to be entered for > CONFIG_ADB/CONFIG_INPUT_ADBHID too. Well, if that's the final word for > 2.4.0... Can we schedule the move for 2.4.1 then? > > Who will send the joystick Makefile/Config.in patch to Linus? Please send it > ASAP, I'll do the hackery for CONFIG_INPUT_ADBHID after that then. Unfortunately, to enter the USB dir, one needs to set CONFIG_USB, which in return means that usbcore.o will get linked in or at least built as a module even when not needed at all :( -- Vojtech Pavlik SuSE Labs |