Re: Asian keyboards and input.h KEY_* defines

[Vojtech P. <vo...@su...>]

On Mon, Jul 24, 2000 at 01:18:56AM +0200, Franz Sirl wrote:
> On Sun, 23 Jul 2000, Vojtech Pavlik wrote:
> > On Sun, Jul 23, 2000 at 07:17:18PM +0200, Franz Sirl wrote:
> > If you could also patch the attached list of scancodes with the added
> > stuff, I'd be grateful ...
> 
> Which attachment? Maybe you should checkin that to ruby :-).

I forgot to attach it. Ok, it's in ruby, under utils/

> > > Appended a new patch, which does
> > > it like you suggest. Mind you that I still didn't touch keycodes 179 and
> > > 180 which seem to disagree between input.h and evtest.c (which says they
> > > are KPLeftParenthesis and KPRightParenthesis).
> >
> > Added to input.h
> 
> Thanks. I've got another report now on the USB KPComma key (0x85), is it safe 
> to map that to KEY_KPDOT, or do keyboards with both of them exist?

I hope it's safe, I haven't seen a keyboard with both yet.

> > I hope Linus will accept it. The split (drivers/usb +
> > drivers/char/joystick) already is causing trouble.
> 
> Any feedback from Linus yet?

No, and I doubt there will be any - either the patch appears in some of
the later kernels or not.

> > Great. Well, you can send it even if it's not tested - ruby is a
> > development tree, many things there don't event compile.
> 
> OK, I have to make some decisions still, but after that I'll send it.

Thanks.

> > Thank you. You know, it really makes me happy hearing this.
> 
> Well, that's the way I feel after working with the code. There are some minor 
> loose ends, but I really like the design.

Yes, I believe it'll get better with time.

-- 
Vojtech Pavlik
SuSE Labs