From: James S. <jsi...@ac...> - 2000-04-09 00:04:40
|
> > console.h just have the basic functions to get a console going > > independent of the hardware underneath. vc_data represents the virtual > > console. We could seperate out the VT switching code and make it generic. > > This allows for VCs on serial consoles and other types of consoles. Thus > > vc_data can act as a place to store the console current state on VT > > switching. Move all video terminal related data to vt_kern.h. Get ride of > > kd.h and merge it in its proper place. So what do you think ? Opinions, > > flames :-> > > There is entirely too much "magic" going on in console.c. All those macros > in console_macros.h, i really hate them. I am pretty much inclined to rip > the thing apart an just pass _one_ pointer around like *BSD does in pcvt. I > think we're in for a major clean-up job here... I agree with you on the macro thing. I don't understand either why not just use a pointer. Yeah it's going to be a major cleanup job. Also why is console_map_init() in driver/block/genhd.c ? I going to do some cleanup tonight and tomorrow. I also like to rename console.c to vt.c and vt.c to vt_ioctl.c. I just makes sense. At least to me. "Look it's a text editor, no it's a OS, no it's Emacs" James Simmons ____/| fbdev/gfx developer \ o.O| http://www.linux-fbdev.org =(_)= http://linuxgfx.sourceforge.net U |