I have started to make "global" options more specific to the driver. For
example to invert the color map. It would be really nice if we asked to
invert the colormap for certain framebuffer drivers. Alot of drivers do
this in their own setup functions. What I was thinking was to put these
"general" options in video_setup and call them from their. This would work
if we can pass strut fb_info to these general functions i.e
fb_invert_cmap(struct fb_info). In order to do this tho I need the struct
fb_info for that frmaebuffer. So I like to suggest for a solution in 2.5.X
is to change
static struct {
const char *name;
int (*init)(void);
int (*setup)(char*);
} fb_drivers[] __initdata = {
to:
static struct {
struct fb_info* (*init)(void);
int (*setup)(char*);
} fb_drivers[] __initdata = {
We don't need the name field since this is already in struct fb_info. What
do you think?
|