linuxconsole-dev

Porting ruby to 2.6.5... partialy succes here either :-)

[Aivils <ai...@un...>]

Hi all!

	Comrad Daniel Sobe make bigest part and i make a rest. None of
phantom or real bugs are patched. Instead pop up strange things.
code may reach public CVS in 24h betwin 24 days :)

Aivils

???????????????????????????????????????????????????????
???????????????????????????????????????????????????????
???????????????????????????????????????????????????????
> On Tue, 2004-04-20 at 17:58, Aivils wrote:
> > Hi all!
> >=20
> > =A0=A0=A0=A0=A0=A0My 2.6.5 will not start until i applay patch bellow:
> > --- linux-2.6.5/kernel/softirq.c =A0 =A0 =A0 =A02004-04-04 06:36:47.000=
000000 +0300
> > +++ linux-2.6.5/kernel/softirq.chg.c =A0 =A02004-04-20 10:48:28.0000000=
00 +0300
> > @@ -409,8 +409,8 @@ static int __devinit cpu_callback(struct
> >=20
> > =A0 =A0 =A0 =A0 switch (action) {
> > =A0 =A0 =A0 =A0 case CPU_UP_PREPARE:
> > - =A0 =A0 =A0 =A0 =A0 =A0 =A0 BUG_ON(per_cpu(tasklet_vec, hotcpu).list);
> > - =A0 =A0 =A0 =A0 =A0 =A0 =A0 BUG_ON(per_cpu(tasklet_hi_vec, hotcpu).li=
st);
> > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 per_cpu(tasklet_vec, hotcpu).list =3D NUL=
L;
> > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 per_cpu(tasklet_hi_vec, hotcpu).list =3D =
NULL;
> > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 p =3D kthread_create(ksoftirqd, hcpu, "=
ksoftirqd/%d", hotcpu);
> > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 if (IS_ERR(p)) {
> > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 printk("ksoftirqd for %=
i failed\n", hotcpu);
>=20
> This patch should be completely unnecessary.
>=20
> One possibility is that your compiler isn't obeying the section
> attribute for some reason. =A0Please send .config and output of "gcc -v".
>=20
> Thanks!
> Rusty.
> --=20
> Anyone who quotes me in their signature is an idiot -- Rusty Russell
>
???????????????????????????????????????????????????????=20
???????????????????????????????????????????????????????
???????????????????????????????????????????????????????

Re: Porting ruby to 2.6.5... partialy succes here either :-)

[Svetoslav S. <sv...@gm...>]

> Hi all!
> 
> 	Comrad Daniel Sobe make bigest part and i make a rest. None of
> phantom or real bugs are patched. Instead pop up strange things.
> code may reach public CVS in 24h betwin 24 days :)
> 
> Aivils

Hi Aivils,

you are my hero !!!

:-)

thank you very much on getting back on it  :-)

> ???????????????????????????????????????????????????????
> ???????????????????????????????????????????????????????
> ???????????????????????????????????????????????????????
> > On Tue, 2004-04-20 at 17:58, Aivils wrote:
> > > Hi all!
> > > 
> > >       My 2.6.5 will not start until i applay patch bellow:
> > > --- linux-2.6.5/kernel/softirq.c        2004-04-04 06:36:47.000000000
> +0300
> > > +++ linux-2.6.5/kernel/softirq.chg.c    2004-04-20 10:48:28.000000000
> +0300
> > > @@ -409,8 +409,8 @@ static int __devinit cpu_callback(struct
> > > 
> > >         switch (action) {
> > >         case CPU_UP_PREPARE:
> > > -               BUG_ON(per_cpu(tasklet_vec, hotcpu).list);
> > > -               BUG_ON(per_cpu(tasklet_hi_vec, hotcpu).list);
> > > +               per_cpu(tasklet_vec, hotcpu).list = NULL;
> > > +               per_cpu(tasklet_hi_vec, hotcpu).list = NULL;
> > >                 p = kthread_create(ksoftirqd, hcpu, "ksoftirqd/%d",
> hotcpu);
> > >                 if (IS_ERR(p)) {
> > >                         printk("ksoftirqd for %i failed\n", hotcpu);
> > 
> > This patch should be completely unnecessary.
> > 
> > One possibility is that your compiler isn't obeying the section
> > attribute for some reason.  Please send .config and output of "gcc -v".
> > 
> > Thanks!
> > Rusty.
> > -- 
> > Anyone who quotes me in their signature is an idiot -- Rusty Russell
> >

i think i was hitting the same issue with 2.6.5, reverted all relevant IMO
patches + ruby-2.6.3

once again, thanks, thanks a lot for your work

best,

svetljo

PS.
the prefbusid patch applies and builds cleanly against Xorg X11 release,
i didn't try it with ruby, but i've uploaded it to mandrakeclub
/* although it still not available there */
sadly i think i don't have that much web space to upload it to
karlovo.demon.co.uk

PS.2
now that you've released 2.6.5 i may try to cook up something for mandrake
cooker or club /* which evetually could be included in next mdk release */

-- 
"Sie haben neue Mails!" - Die GMX Toolbar informiert Sie beim Surfen!
Jetzt aktivieren unter http://www.gmx.net/info

Re: Porting ruby to 2.6.5... partialy succes here either :-)

[Zoltan B. <zb...@fr...>]

Hi!

Svetoslav Slavtchev =EDrta:
>>Hi all!
>>
>>	Comrad Daniel Sobe make bigest part and i make a rest. None of
>>phantom or real bugs are patched. Instead pop up strange things.
>>code may reach public CVS in 24h betwin 24 days :)
>>
>>Aivils
>=20
>=20
> Hi Aivils,
>=20
> you are my hero !!!
>=20
> :-)
>=20
> thank you very much on getting back on it  :-)
>=20
>=20
>>???????????????????????????????????????????????????????
>>???????????????????????????????????????????????????????
>>???????????????????????????????????????????????????????
>>
>>>On Tue, 2004-04-20 at 17:58, Aivils wrote:
>>>
>>>>Hi all!
>>>>
>>>>      My 2.6.5 will not start until i applay patch bellow:
>>>>--- linux-2.6.5/kernel/softirq.c        2004-04-04 06:36:47.000000000
>>
>>+0300
>>
>>>>+++ linux-2.6.5/kernel/softirq.chg.c    2004-04-20 10:48:28.000000000
>>
>>+0300
>>
>>>>@@ -409,8 +409,8 @@ static int __devinit cpu_callback(struct
>>>>
>>>>        switch (action) {
>>>>        case CPU_UP_PREPARE:
>>>>-               BUG_ON(per_cpu(tasklet_vec, hotcpu).list);
>>>>-               BUG_ON(per_cpu(tasklet_hi_vec, hotcpu).list);
>>>>+               per_cpu(tasklet_vec, hotcpu).list =3D NULL;
>>>>+               per_cpu(tasklet_hi_vec, hotcpu).list =3D NULL;
>>>>                p =3D kthread_create(ksoftirqd, hcpu, "ksoftirqd/%d",
>>
>>hotcpu);
>>
>>>>                if (IS_ERR(p)) {
>>>>                        printk("ksoftirqd for %i failed\n", hotcpu);
>>>
>>>This patch should be completely unnecessary.
>>>
>>>One possibility is that your compiler isn't obeying the section
>>>attribute for some reason.  Please send .config and output of "gcc -v".
>>>
>>>Thanks!
>>>Rusty.
>>>--=20
>>>Anyone who quotes me in their signature is an idiot -- Rusty Russell
>>>
>=20
>=20
> i think i was hitting the same issue with 2.6.5, reverted all relevant =
IMO
> patches + ruby-2.6.3
>=20
> once again, thanks, thanks a lot for your work
>=20
> best,
>=20
> svetljo

I also thank you. This two-liner made it possible to run
2.6.6-rc2-mm1-ruby now. :-)

The hotplug CPU patches changed this in 2.6.4,
I wonder why it booted up without the -ruby patch
and why it didn't with it. It well may be an unfortunate
timing. :-(

Best regards,
Zolt=E1n B=F6sz=F6rm=E9nyi

Re: Porting ruby to 2.6.5... partialy succes here either :-)

[Zoltan B. <zb...@fr...>]

Hi,

if you are interested, here's the patches that were needed
to build and run 2.6.6-rc2-mm1-ruby. (ruby-2.6.5.patch omitted.)

Patch against 2.6.6-rc2 so ruby-2.6.5 generates only trivial rejects:
2.6.6-rc2-to-be-reverted-in-ruby.patch

This is mainly about whitespace fixes and cast removal. vt_ioctl.c
has one less empty line at the end in mainline, it causes a 80+ kB
reject.

"2.6.6-rc2-to-be-reverted-in-ruby-1.patch" is the part of that
that needed thinking. E.g. is it needed to move vcs_init() in
vty_init()? Anyway, I applied it and the locking change in
con_close()/vt_close().

The con_open() / vt_open() change is not clear: placing everything
inside of "if (tty->count =3D=3D 1) { ... }" and returning error code
instead of 0 always. May also be needed in ruby. (?)

Then ruby-2.6.5.patch was applied, drivers/pci/proc.c in mainline
already has the same locking fix that is in ruby, only the semaphor
is kept in a variable instead of evaluating the pointers twice.
The Makefile version reject was trivial. :-)

Then 2.6.6-rc2-mm1 was applied, keyboard.c has a trivial reject,
and nothing else! (Harmless and does nothing without KGDB.)

Here is the patch against the ruby-2.6 tree so it is now against
linux-2.6.6-rc2-mm1.

I also attached the patch against kernel/softirq.c. Needed to boot. :-)

Best regards,
Zolt=E1n B=F6sz=F6rm=E9nyi

Zoltan Boszormenyi =EDrta:
> I also thank you. This two-liner made it possible to run
> 2.6.6-rc2-mm1-ruby now. :-)

Re: Porting ruby to 2.6.5... partialy succes here either :-)

[James S. <jsi...@in...>]

> Hi Aivils,
> 
> you are my hero !!!
> 
> :-)
> 
> thank you very much on getting back on it  :-)

Great work. Sorry I have been away. I have new merges for fbcon going 
mainline soon :-)

Re: Porting ruby to 2.6.5... partialy succes here either :-)

[Aivils <ai...@un...>]

On Saturday 24 April 2004 02:26, James Simmons wrote:
> Great work. Sorry I have been away. I have new merges for fbcon going 
> mainline soon :-)

Please make this soft words more harder via explanation of "MAINLINE".
Otherwise You alone understand what You mean.

Aivils