linuxconsole-dev

Re: evdev types

[Brad H. <bh...@bi...>]

On Tue, 23 Apr 2002 01:10, Vojtech Pavlik wrote:
> On Mon, Apr 22, 2002 at 06:40:25PM +1000, Brad Hards wrote:
<snip>
> > I can maybe do some patches for the input system for 2.4 if you just need
> > grunt work.
>
> It would be nice, if you could. I'm rather low on time right now (should
> be better after a couple weeks), because of other projects (robotic cup,
> wedding, ...).
Congratulations!

I am working on the patches.

I am trying for the following breakdown:
Patch 1 - changes to 2.4.19-pre7 from CVS that are userspace visible (ie the 
evdev ioctl's). I am doing it without my changes (and some equivalent changes 
to the new "set global state" ioctls). I will send those when this set is 
accepted.

Patch 2 - changes to 2.4.19-pre7 from CVS to implement the revised modular 
system, including hotplug

Patch 3 - changes to 2.4.19-pre7 from CVS to implement /proc

Patch 4 - changes to 2.4.19-pre8 (or whatever patch the first three go into, 
plus 1 non-rc)  from CVS for FF.

Patch 5 - minor changes (Vojtech's email address, Suse deletion, etc)

Patch 6 (in 2.4.20-pre, probably) to provide structures for ioctl argp's, as 
appropriate, based on my prior set of patches.

Questions:
1. Johann - do you think the FF stuff is stable enough? I don't have any 
device to try it yet, so I think that maybe I have to defer Patch 4 to you.

2. I'm not planning to make patches for evbug, power or tsdev drivers into 2.4 
at this stage. Does this seem reasonable to developers? Also, I'm leaving out 
all the pm stuff - again, does this seem reasonable at this stage?

3. In input.c:input_call_hotplug(), there is a KERN_ERR that says:
"input.c: calling hotplug a hotplug agent defined\n"
is that supposed to be:
"input.c: calling hotplug without a hotplug agent defined\n" ?

4, The patches will likely be fairly large  (circa 2000 lines). Do developers 
want to see them posted to the list as well as sent to Vojtech for 
onforwarding to Marcelo?

Brad

Re: evdev types

[Johann D. <jo...@do...>]

Brad Hards wrote:
> On Tue, 23 Apr 2002 01:10, Vojtech Pavlik wrote:
> 
>>On Mon, Apr 22, 2002 at 06:40:25PM +1000, Brad Hards wrote:
>>
> <snip>
> 
>>>I can maybe do some patches for the input system for 2.4 if you just need
>>>grunt work.
>>>
>>It would be nice, if you could. I'm rather low on time right now (should
>>be better after a couple weeks), because of other projects (robotic cup,
>>wedding, ...).
>>
> Congratulations!
> 
> I am working on the patches.
> 
> I am trying for the following breakdown:
> Patch 1 - changes to 2.4.19-pre7 from CVS that are userspace visible (ie the 
> evdev ioctl's). I am doing it without my changes (and some equivalent changes 
> to the new "set global state" ioctls). I will send those when this set is 
> accepted.
> 
> Patch 2 - changes to 2.4.19-pre7 from CVS to implement the revised modular 
> system, including hotplug
> 
> Patch 3 - changes to 2.4.19-pre7 from CVS to implement /proc
> 
> Patch 4 - changes to 2.4.19-pre8 (or whatever patch the first three go into, 
> plus 1 non-rc)  from CVS for FF.
> 
> Patch 5 - minor changes (Vojtech's email address, Suse deletion, etc)
> 
> Patch 6 (in 2.4.20-pre, probably) to provide structures for ioctl argp's, as 
> appropriate, based on my prior set of patches.
> 
> Questions:
> 1. Johann - do you think the FF stuff is stable enough? I don't have any 
> device to try it yet, so I think that maybe I have to defer Patch 4 to you.
> 

You mean the API or the drivers ? The API looks ok, except for the 
rumble effects. There is a big chance that struct ff_rumble_effect 
changes. Other ff* stuff shouldn't move.
The I-Force driver is stable enough to be actually used in games. Other 
drivers (PID, Logitech) aren't yet functional.

I can take care of this patch.

> 2. I'm not planning to make patches for evbug, power or tsdev drivers into 2.4 
> at this stage. Does this seem reasonable to developers? Also, I'm leaving out 
> all the pm stuff - again, does this seem reasonable at this stage?
> 
> 3. In input.c:input_call_hotplug(), there is a KERN_ERR that says:
> "input.c: calling hotplug a hotplug agent defined\n"
> is that supposed to be:
> "input.c: calling hotplug without a hotplug agent defined\n" ?
> 
> 4, The patches will likely be fairly large  (circa 2000 lines). Do developers 
> want to see them posted to the list as well as sent to Vojtech for 
> onforwarding to Marcelo?

I don't mind receiving big mails, but I can't talk for everyone. Perhaps 
you could make them available by ftp or http and post the URL ?

-- 
Johann Deneux

Re: evdev types

[Vojtech P. <vo...@su...>]

On Mon, Apr 29, 2002 at 09:24:55PM +1000, Brad Hards wrote:
> On Tue, 23 Apr 2002 01:10, Vojtech Pavlik wrote:
> > On Mon, Apr 22, 2002 at 06:40:25PM +1000, Brad Hards wrote:
> <snip>
> > > I can maybe do some patches for the input system for 2.4 if you just need
> > > grunt work.
> >
> > It would be nice, if you could. I'm rather low on time right now (should
> > be better after a couple weeks), because of other projects (robotic cup,
> > wedding, ...).
> Congratulations!
> 
> I am working on the patches.
> 
> I am trying for the following breakdown:
> Patch 1 - changes to 2.4.19-pre7 from CVS that are userspace visible (ie the 
> evdev ioctl's). I am doing it without my changes (and some equivalent changes 
> to the new "set global state" ioctls). I will send those when this set is 
> accepted.
> 
> Patch 2 - changes to 2.4.19-pre7 from CVS to implement the revised modular 
> system, including hotplug
> 
> Patch 3 - changes to 2.4.19-pre7 from CVS to implement /proc
> 
> Patch 4 - changes to 2.4.19-pre8 (or whatever patch the first three go into, 
> plus 1 non-rc)  from CVS for FF.
> 
> Patch 5 - minor changes (Vojtech's email address, Suse deletion, etc)
> 
> Patch 6 (in 2.4.20-pre, probably) to provide structures for ioctl argp's, as 
> appropriate, based on my prior set of patches.

Ok.

> Questions:
> 1. Johann - do you think the FF stuff is stable enough? I don't have any 
> device to try it yet, so I think that maybe I have to defer Patch 4 to you.
> 
> 2. I'm not planning to make patches for evbug, power or tsdev drivers into 2.4 
> at this stage. Does this seem reasonable to developers? Also, I'm leaving out 
> all the pm stuff - again, does this seem reasonable at this stage?

Yes.

> 3. In input.c:input_call_hotplug(), there is a KERN_ERR that says:
> "input.c: calling hotplug a hotplug agent defined\n"
> is that supposed to be:
> "input.c: calling hotplug without a hotplug agent defined\n" ?

That's right.

> 4, The patches will likely be fairly large  (circa 2000 lines). Do developers 
> want to see them posted to the list as well as sent to Vojtech for 
> onforwarding to Marcelo?
> 
> Brad

-- 
Vojtech Pavlik
SuSE Labs

Re: evdev types

[Brad H. <bh...@bi...>]

On Tue, 30 Apr 2002 00:42, Vojtech Pavlik wrote:
> On Mon, Apr 29, 2002 at 09:24:55PM +1000, Brad Hards wrote:
> > Patch 1 - changes to 2.4.19-pre7 from CVS that are userspace visible (ie
> > the evdev ioctl's). I am doing it without my changes (and some equivalent
> > changes to the new "set global state" ioctls). I will send those when
> > this set is accepted.
OK, I have completed this part, and done some simple testing. I haven't tested 
every ioctl() - eg. I don't have a HID device with a serial number to test 
the EVIOCGUNIQ ioctl.

The split is partly to reduce the size of each patch, and also so the 
ioctldrivers patch (which is basically USB changes) can go to Greg K-H, if 
required.

This change doesn't have the sprintf->snprintf change. I think it is safe the 
way it is, and I'll clean it up in a future change. 2.4.19-pre is pretty late 
(next change, rc1) and I'd prefer to only put in stuff that is basically the 
same as 2.5/ linuxconsole CVS (or where I really understand what I am doing 
:).

If this looks reasonable, can you pass this to Marcelo?

Brad

Re: evdev types

[Vojtech P. <vo...@su...>]

On Fri, May 03, 2002 at 09:38:15PM +1000, Brad Hards wrote:
> On Tue, 30 Apr 2002 00:42, Vojtech Pavlik wrote:
> > On Mon, Apr 29, 2002 at 09:24:55PM +1000, Brad Hards wrote:
> > > Patch 1 - changes to 2.4.19-pre7 from CVS that are userspace visible (ie
> > > the evdev ioctl's). I am doing it without my changes (and some equivalent
> > > changes to the new "set global state" ioctls). I will send those when
> > > this set is accepted.
> OK, I have completed this part, and done some simple testing. I haven't tested 
> every ioctl() - eg. I don't have a HID device with a serial number to test 
> the EVIOCGUNIQ ioctl.
> 
> The split is partly to reduce the size of each patch, and also so the 
> ioctldrivers patch (which is basically USB changes) can go to Greg K-H, if 
> required.
> 
> This change doesn't have the sprintf->snprintf change. I think it is safe the 
> way it is, and I'll clean it up in a future change. 2.4.19-pre is pretty late 
> (next change, rc1) and I'd prefer to only put in stuff that is basically the 
> same as 2.5/ linuxconsole CVS (or where I really understand what I am doing 
> :).
> 
> If this looks reasonable, can you pass this to Marcelo?

I did. However note that you'll most likely need to update the
drivers/char/joystick drivers as well to follow the changes - not only
USB uses input on 2.4 ...

-- 
Vojtech Pavlik
SuSE Labs

Re: evdev types

[Brad H. <bh...@bi...>]

On Fri, 3 May 2002 21:49, Vojtech Pavlik wrote:
> I did. However note that you'll most likely need to update the
> drivers/char/joystick drivers as well to follow the changes - not only
> USB uses input on 2.4 ...
The USB stuff is what I can test. However I'd forgotten about the joystick 
stuff. I might be able to find the adapter for a joystick which turns it back 
into gameport, but won't be able to do them all.

I'll have a look at this (and maybe the ADB stuff, which I had thought about, 
and also can't test).

Brad

Re: evdev types

[Vojtech P. <vo...@su...>]

On Fri, May 03, 2002 at 10:02:05PM +1000, Brad Hards wrote:

> On Fri, 3 May 2002 21:49, Vojtech Pavlik wrote:
> > I did. However note that you'll most likely need to update the
> > drivers/char/joystick drivers as well to follow the changes - not only
> > USB uses input on 2.4 ...
> The USB stuff is what I can test. However I'd forgotten about the joystick 
> stuff. I might be able to find the adapter for a joystick which turns it back 
> into gameport, but won't be able to do them all.
> 
> I'll have a look at this (and maybe the ADB stuff, which I had thought about, 
> and also can't test).

It might be enough to copy them over from 2.5. Or at least make them
compile (which shouldn't be too tough).

-- 
Vojtech Pavlik
SuSE Labs

Re: evdev types

[Brad H. <bh...@bi...>]

On Fri, 3 May 2002 22:19, Vojtech Pavlik wrote:
> On Fri, May 03, 2002 at 10:02:05PM +1000, Brad Hards wrote:
> > On Fri, 3 May 2002 21:49, Vojtech Pavlik wrote:
> > > I did. However note that you'll most likely need to update the
> > > drivers/char/joystick drivers as well to follow the changes - not only
> > > USB uses input on 2.4 ...
> >
> > The USB stuff is what I can test. However I'd forgotten about the
> > joystick stuff. I might be able to find the adapter for a joystick which
> > turns it back into gameport, but won't be able to do them all.
> >
> > I'll have a look at this (and maybe the ADB stuff, which I had thought
> > about, and also can't test).
>
> It might be enough to copy them over from 2.5. Or at least make them
> compile (which shouldn't be too tough).
I have looked at the differences, and think that I don't need to add anything 
to 2.4, because all of the changes are extensions (although EVIOCGPHYS will 
fail, because not all drivers support it - although not all drivers support 
it in CVS or 2.5 either).

I'll do the ->phys change though.

Brad

[patch] joystick changes for 2.4.19-pre8 [was Re: evdev types]

[Brad H. <bh...@bi...>]

On Sun, 5 May 2002 18:14, Brad Hards wrote:
> I'll do the ->phys change though.
Changes attached, against 2.4.19-pre8 + three previous changes.

I have tested this for compilation (not booted or tested though). Not sure 
whether you want to put this in an -rc release or not.

Brad

Re: [patch] joystick changes for 2.4.19-pre8 [was Re: evdev types]

[Vojtech P. <vo...@su...>]

On Sun, May 05, 2002 at 09:51:30PM +1000, Brad Hards wrote:

> On Sun, 5 May 2002 18:14, Brad Hards wrote:
> > I'll do the ->phys change though.
> Changes attached, against 2.4.19-pre8 + three previous changes.
> 
> I have tested this for compilation (not booted or tested though). Not sure 
> whether you want to put this in an -rc release or not.
> 
> Brad

It looks good, I'll read it thoroughly once more and then send all three to
Marcelo. OK?

-- 
Vojtech Pavlik
SuSE Labs