Thread: Input patch ...

SourceForge Headquarters 225 Broadway Suite 1600 San Diego, CA 92101 +1 (858) 422-6466

Hi!

I've created a input-only patch for 2.5.3-pre1. I've sent it to Dave
Jones, too ...

http://atrey.karlin.mff.cuni.cz/~vojtech/input9.diff.bz2

-- 
Vojtech Pavlik
SuSE Labs

> Hi!
> 
> I've created a input-only patch for 2.5.3-pre1. I've sent it to Dave
> Jones, too ...
> 
> http://atrey.karlin.mff.cuni.cz/~vojtech/input9.diff.bz2

Nice :-) One thing I noticed. You did manage to move all the input devices
to drivers/input. Now when you did you created a bunch of directories. How
does Linus feel about this? Was the subdirectories apart of the compromise
for linus to allow all the drivers to be moved to drivers/input. The most
important thing is the issue of many drivers needing serio.o handled
properly. The cross directory thing was a pain to deal with. I will give
it a try. 

P.S 
   Some of the stuff was already synced to DJ tree :-) 

On Sat, Jan 19, 2002 at 08:26:45PM -0800, James Simmons wrote:
> 
> > Hi!
> > 
> > I've created a input-only patch for 2.5.3-pre1. I've sent it to Dave
> > Jones, too ...
> > 
> > http://atrey.karlin.mff.cuni.cz/~vojtech/input9.diff.bz2
> 
> Nice :-) One thing I noticed. You did manage to move all the input devices
> to drivers/input. Now when you did you created a bunch of directories. How
> does Linus feel about this? Was the subdirectories apart of the compromise
> for linus to allow all the drivers to be moved to drivers/input. The most
> important thing is the issue of many drivers needing serio.o handled
> properly. The cross directory thing was a pain to deal with. I will give
> it a try. 

Not sure, I didn't check with Linus yet. However I talked with DJ about
this for a long time and this seemed the only reasonable way to do it.

Note I didn't move the USB and ADB stuff which is still in the
respective directories. I only moved stuff out of drivers/char, which is
not a good place for input drivers anyway.

I like it better than one big input directory as well - now the problem
is how to sync CVS to this layout without losing history on all the
files.

> P.S 
>    Some of the stuff was already synced to DJ tree :-) 

I noticed only after I sent it out. I'll have to go through it again and
check what is different.

-- 
Vojtech Pavlik
SuSE Labs

> Not sure, I didn't check with Linus yet. However I talked with DJ about
> this for a long time and this seemed the only reasonable way to do it.

Okay. Also long as cross directory dependency are not a issues. 

> Note I didn't move the USB and ADB stuff which is still in the
> respective directories. I only moved stuff out of drivers/char, which is
> not a good place for input drivers anyway.

For now. Later we can move stuff. 

> I like it better than one big input directory as well - now the problem
> is how to sync CVS to this layout without losing history on all the
> files.

I don't picture that being to hard. It is a matter of moving files around
with cvs commands.

On Sun, Jan 20, 2002 at 06:44:25AM -0800, James Simmons wrote:
> 
> > Not sure, I didn't check with Linus yet. However I talked with DJ about
> > this for a long time and this seemed the only reasonable way to do it.
> 
> Okay. Also long as cross directory dependency are not a issues. 
> 
> > Note I didn't move the USB and ADB stuff which is still in the
> > respective directories. I only moved stuff out of drivers/char, which is
> > not a good place for input drivers anyway.
> 
> For now. Later we can move stuff. 

Actually, I don't mind the USB stuff staying where it is. There are
always two places for a driver to be: with other drivers for the bus it
lives on (like USB), or with other drivers that have the same interface
(like V4L or SCSI or Input ...).

> > I like it better than one big input directory as well - now the problem
> > is how to sync CVS to this layout without losing history on all the
> > files.
> 
> I don't picture that being to hard. It is a matter of moving files around
> with cvs commands.

I don't think there is anything like 'cvs move'. And if you do 'mv; cvs
remove; cvs add', you lose versions and the whole history of the file.

-- 
Vojtech Pavlik
SuSE Labs

> > For now. Later we can move stuff. 
> 
> Actually, I don't mind the USB stuff staying where it is. There are
> always two places for a driver to be: with other drivers for the bus it
> lives on (like USB), or with other drivers that have the same interface
> (like V4L or SCSI or Input ...).

Okay. Personally I hate the idea of drivers in bus directories but that is
my personal taste. 

> I don't think there is anything like 'cvs move'. And if you do 'mv; cvs
> remove; cvs add', you lose versions and the whole history of the file.

Yuck! 

On Sun, Jan 20, 2002 at 06:49:56AM -0800, James Simmons wrote:

> > Actually, I don't mind the USB stuff staying where it is. There are
> > always two places for a driver to be: with other drivers for the bus it
> > lives on (like USB), or with other drivers that have the same interface
> > (like V4L or SCSI or Input ...).
> 
> Okay. Personally I hate the idea of drivers in bus directories but that is
> my personal taste. 

Linus prefers it, and really I'm not going to be the judge here.

> 
> > I don't think there is anything like 'cvs move'. And if you do 'mv; cvs
> > remove; cvs add', you lose versions and the whole history of the file.
> 
> Yuck! 

Yeah. The only known way to solve this is to ssh into the CVS server and
move both the files and their histories manually. Well, perhaps the
history can be retrieved and stored from/to the CVS server as well some
way without ssh access.

-- 
Vojtech Pavlik
SuSE Labs

> > Okay. Personally I hate the idea of drivers in bus directories but that is
> > my personal taste. 
> 
> Linus prefers it, and really I'm not going to be the judge here.

:-/

> Yeah. The only known way to solve this is to ssh into the CVS server and
> move both the files and their histories manually. Well, perhaps the
> history can be retrieved and stored from/to the CVS server as well some
> way without ssh access.

No ssh access to CVS on SF. Hm. I can find out. 

> 
> -- 
> Vojtech Pavlik
> SuSE Labs
> 

Thread: Input patch ...

linuxconsole-dev