linuxconsole-dev

Status: Conversion to input layer on PPC

[Franz S. <Fra...@la...>]

Hi,

the move to the input layer on PPC with the 2.2 USB backport works quite 
well so far, the problems remaining so far are:

- the input layer drivers are not built if CONFIG_USB=n, can that please be 
changed in 2.4? So we can get these built if CONFIG_ADB is set? I'll take 
care to call input_init_module() in adb.c if CONFIG_USB=n then. This is 
quite important for us, since we could completely convert ADB to the input 
layer in 2.4 already.

- keyboard problems with japanese keyboards, on both USB and ADB some keys 
are not recognized yet:

<Hiragana_Katakana> key aka kana (KEY_JPN?), USB 0x90, ADB 0x68
<Eisu> key aka "english" (KEY_?),            USB 0x91, ADB 0x66
_ key, underscore (KEY_?),                   USB 0x87, ADB 0x5e
|\ key, bar+backslash (KEY_?),               USB 0x89, ADB 0x5d

see http://developer.apple.com/technotes/tn/tn1152.html#JISKeyboards for a 
picture of the keyboard. I'll get a list of the ADB keycodes soon, so 
probably I can overlap the _ and the |\ key with existing KEY_* mappings, 
that are present on ANSI/ISO keyboards, but not on JIS keyboards. For the 
"kana" key, the choice is pretty obvious, or? Don't know what to do with 
the "eisu" one yet...

- one button mouse support: this requires small changes in keybdev.c and 
mousedev.c, all wrapped into CONFIG_MAC_EMUMOUSEBTN. Any objections to 
include that?

Franz.

Re: Status: Conversion to input layer on PPC

[Christoph H. <chh...@gm...>]

On Fri, Jul 14, 2000 at 01:15:57PM +0200, Franz Sirl wrote:
> - the input layer drivers are not built if CONFIG_USB=n, can that please be 
> changed in 2.4?

This is really a good idea. In 2.4 the joystick driver use the input layer, too.
IMHO we should move all input drivers to drivers/input and maybe add the
serial mouse driver and convert the busmouse drivers to the input layer.

This would give linux 2.4 a coherent mouse interface without too much work.


	Christoph

-- 
Always remember that you are unique.  Just like everyone else.

Re: Status: Conversion to input layer on PPC

[Franz S. <Fra...@la...>]

At 14:37 14.07.00, Christoph Hellwig wrote:
>On Fri, Jul 14, 2000 at 01:15:57PM +0200, Franz Sirl wrote:
> > - the input layer drivers are not built if CONFIG_USB=n, can that 
> please be
> > changed in 2.4?
>
>This is really a good idea. In 2.4 the joystick driver use the input 
>layer, too.
>IMHO we should move all input drivers to drivers/input and maybe add the
>serial mouse driver and convert the busmouse drivers to the input layer.
>
>This would give linux 2.4 a coherent mouse interface without too much work.

Maybe already too invasive for Linus right now, that's why I kept my 
request to a minimum, it would only require a small reshuffle of 
drivers/usb/Config.in and drivers/usb/Makefile. Certainly I would prefer to 
get a separate drivers/input/ in 2.4 (it's the much cleaner solution), but 
I fear it might not be accepted... Anyone already talked to Linus about 
that? Should I first try to send Linus a patch to create drivers/input and 
move the input stuff over from drivers/usb? Doing nothing else to the code, 
just a pure move and Config.in/Makefile.in adjustment?

Franz.

Re: Status: Conversion to input layer on PPC

[Christoph H. <chh...@gm...>]

On Fri, Jul 14, 2000 at 08:00:33PM +0200, Franz Sirl wrote:
> Maybe already too invasive for Linus right now, that's why I kept my 
> request to a minimum, it would only require a small reshuffle of 
> drivers/usb/Config.in and drivers/usb/Makefile.

Ok.

> Certainly I would prefer to 
> get a separate drivers/input/ in 2.4 (it's the much cleaner solution), but 
> I fear it might not be accepted... Anyone already talked to Linus about 
> that?

/me not

> Should I first try to send Linus a patch to create drivers/input and 
> move the input stuff over from drivers/usb? Doing nothing else to the code, 
> just a pure move and Config.in/Makefile.in adjustment?

seems like a good ide to me
 - first create drivers/input and move the stuff from drivers/usb and 
	drivers/char/joystick over, then
 - add your adb stuff, then
 - add the serial mouse driver, and then maybe
 - convert the busmouse drivers

That's a real <de>Salami-Taktik</de>.


	Christoph

-- 
Always remember that you are unique.  Just like everyone else.

Re: Status: Conversion to input layer on PPC

[James S. <jsi...@ac...>]

> > Certainly I would prefer to 
> > get a separate drivers/input/ in 2.4 (it's the much cleaner solution), but 
> > I fear it might not be accepted... Anyone already talked to Linus about 
> > that?
> 
> /me not

Sent email to kernel list to see if this could happen. I could generate a
patch for this. I will see the response for this.
 
> seems like a good ide to me

I also like the idea.

>  - first create drivers/input and move the stuff from drivers/usb and 
> 	drivers/char/joystick over, then
>  - add your adb stuff, then
>  - add the serial mouse driver, and then maybe
>  - convert the busmouse drivers

That's what should be done.

Q: Why did they deprecate a.out support in linux?
A: Because a nasty coff is bad for your elf.

James Simmons  [jsi...@li...]               ____/| 
fbdev/console/gfx developer                             \ o.O| 
http://www.linux-fbdev.org                               =(_)= 
http://linuxgfx.sourceforge.net                            U
http://linuxconsole.sourceforge.net

Re: Status: Conversion to input layer on PPC

[Vojtech P. <vo...@su...>]

On Fri, Jul 14, 2000 at 08:07:05PM +0200, Christoph Hellwig wrote:

> > Should I first try to send Linus a patch to create drivers/input and 
> > move the input stuff over from drivers/usb? Doing nothing else to the code, 
> > just a pure move and Config.in/Makefile.in adjustment?
> 
> seems like a good ide to me
>  - first create drivers/input and move the stuff from drivers/usb and 
> 	drivers/char/joystick over, then
>  - add your adb stuff, then
>  - add the serial mouse driver, and then maybe
>  - convert the busmouse drivers
> 
> That's a real <de>Salami-Taktik</de>.

I'd suggest first converting the busmouse drivers (already done in the
CVS), and then adding the serial mouse driver, Linus used to be strongly
against serial mouse protocols being in kernel. But when it'll all fit
nicely together, I think he'll see the cleanliness of the approach.

-- 
Vojtech Pavlik
SuSE Labs

Re: Status: Conversion to input layer on PPC

[James S. <jsi...@ac...>]

> I'd suggest first converting the busmouse drivers (already done in the
> CVS), and then adding the serial mouse driver, Linus used to be strongly
> against serial mouse protocols being in kernel. But when it'll all fit
> nicely together, I think he'll see the cleanliness of the approach.

I sent in patch that creates a drivers/input directory for 2.4.X for
linus. I hope he takes it. It's very big. We can send a second patch for
the busmouse. I think he will take the serial mouse driver since it does
make for a unified mouse protocol. I guess the only think that will not go
in are the keyboard drivers. I also see new keyboard driver where added
recently (scan_keyb.c and hp600_keyb.c).  

Q: Why did they deprecate a.out support in linux?
A: Because a nasty coff is bad for your elf.

James Simmons  [jsi...@li...]               ____/| 
fbdev/console/gfx developer                             \ o.O| 
http://www.linux-fbdev.org                               =(_)= 
http://linuxgfx.sourceforge.net                            U
http://linuxconsole.sourceforge.net

Re: Status: Conversion to input layer on PPC

[James S. <jsi...@ac...>]

On Fri, 14 Jul 2000, Christoph Hellwig wrote:

> On Fri, Jul 14, 2000 at 01:15:57PM +0200, Franz Sirl wrote:
> > - the input layer drivers are not built if CONFIG_USB=n, can that please be 
> > changed in 2.4?
> 
> This is really a good idea. In 2.4 the joystick driver use the input layer, too.
> IMHO we should move all input drivers to drivers/input and maybe add the
> serial mouse driver and convert the busmouse drivers to the input layer.
> 
> This would give linux 2.4 a coherent mouse interface without too much work.

I like to see this changed as well. I have been using a serial mouse
for quite sometime with the input layer from our CVS. It works quite
nicely. The only thing I can't see for 2.4.X converting all the
keyboards to the input layer since 2.4.0 final is so close. Everything
could be converted over.

Q: Why did they deprecate a.out support in linux?
A: Because a nasty coff is bad for your elf.

James Simmons  [jsi...@li...]               ____/| 
fbdev/console/gfx developer                             \ o.O| 
http://www.linux-fbdev.org                               =(_)= 
http://linuxgfx.sourceforge.net                            U
http://linuxconsole.sourceforge.net