Re: [lc-devel] Announce: Compressed cache alpha-007 (kernel 2.6.18)

[Nitin G. <nit...@gm...>]

Nitin Gupta wrote:
> Peter Zijlstra wrote:
>> On Wed, 2006-09-20 at 18:23 +0530, Nitin Gupta wrote:
>>
>>>> Don't like the bit_spin_trylock/bit_spin_unlock in handle_ccache_fault;
>>>> what's wrong with TestSetPageLocked() and unlock_page() ?
>>>>
>>> If (PageCompressed(page)) is true then 'page' is 'struct chunk_head'
>>> not 'struct page' and you cannot use unlock_page() on chunk_head.
>>
>> ClearPageLocked()
>>
> 
> But then how will you do equivalent of wait_on_chunk_head() ?
> 
Please ignore above strange reply.

I meant:
bit_spin_trylock() -> TestSetPageLocked()
bit_spin_unlock() -> ClearPageLocked()

didn't seem correct to me. Like, isn't smb_mb_etc..() done by 
bit_spin_unlock() required on SMP?

-- Nitin