Re: [lc-devel] WKdm Problem

[Rodrigo S de C. <ro...@te...>]

Hi Nitin,

Nitin Gupta wrote:
>     I was testing WKdm de/compression algo and surprisingly it's not
> working!! The de-compressed and original text do not match. Rodrigo's
> patch contains exactly this algorithm implementation (did he make some
> changes which I can't see?) and it works (though, I never myself tried
> that patch).
>   

What exactly is not working?

I remember I changed some things in WKdm to make it compile. If I recall 
correctly, WKdm uses some userspace libraries not available in kernel 
space (ceiling/floor math functions?) and I implemented these functions 
somewhere in the code and made them available for WKdm to work. If this 
is the problem you are facing, I may take a look at the code to recall 
with more details.

>     Can somebody please look into WKdm implementation
> (http://www.cs.utexas.edu/users/oops/compressed-caching/WKdm.tgz) and
> tell what's wrong?
>
> (WK4x4 seems to work okay, while LZO is pain in neck to get it into
> kernel...so I've dropped LZO idea for now).
>   

LZO works in my patch, but I cannot remember what I have done for that.

> WKdm is fastest with nice compression ratios so it'll be nice to have
> it working instead of WK4x4 (we can always include both -or more- of
> them later but for now.....).
>   

Remember that WKdm is very nice with swap cache data, but not with 
general page cache data.

Cheers,

Rodrigo