Re: [lc-devel] question

[Rodrigo S. de C. <rc...@im...>]

Hi Murali,

Sorry for the delay.

On Mon, Jul 28, 2003 at 10:44:36PM -0400, Murali Vilayannur N wrote:
> Is this a typo in the statistics accounting initialization?
> 
> memset((void *) &compression_algorithm, 0, sizeof(struct stats_summary));
> 
> Should n't it be either
> 
> a) memset((void *) &compression_algorithm.stats, 0, sizeof(struct 
> stats_summary));
> (OR)
> b) memset((void *) &compression_algorithm, 0, sizeof(struct
>    comp_alg));

You are absolutely correct, the above memset wouldn't initialize all
the compression_algorithm structure, since "struct stats_summary" is
only part of it.

> In any case, isn't the memset redundant (since compression algorithm
> is defined as a global variable)?

Agreed, it is a redundant initialization. This code will be removed.

Thanks a lot for your attention and for reporting this bug.

Best regards,
-- 
Rodrigo