Re: [lc-devel] Re: Compressed Cache and Preempt/Lockbreak

[Rodrigo S. de C. <rc...@im...>]

On Thu, May 16, 2002 at 07:17:53PM +0200, Marc-Christian Petersen wrote:
> On Thursday 16 May 2002 15:19, Rodrigo Souza de Castro wrote:
> > Yes, but I am not sure it's stable though. My main bug report
> > regarding stability is a hang that happens with Paolo Ciarrocchi when
> > he runs mmap001 program from memtest suite.
>
> oh, and only with mmap001 ? 

Paolo is the only one which reported this problem with mmap001. I
can't reproduce it here, for example.

> Nothing else is known to breakage?

Not that I know of. 

> > Thanks for your request. Even if I can't fix that freeze now, I'd like
> > to know what may be causing it.
> i can tell you:
> 
> - cd /usr/src
> - rm -rf linux-2.4.18
> - tar xzpf linux-2.4.18.tar.gz
>   System freeze while tar do untargzip the file.

Great, it's on our Todo list too.

> Another question: Why not ALL of your compressed cache code is ifdef
> signed?  Some of your code removes existing code and replace new,
> other only apply if compressed cache is selected.

It's not very nice to add #ifdefs all over the original code and that
procedure it's not advisable in Documentation/CodyingStyle document
either.

Actually there are some function calls that are replaced by compressed
cache functions, but all these functions have #ifdefs in our header
file comp_cache.h. That way, if you have compressed cache disabled,
these new compressed cache functions will be static inline functions
that will call the original ones, not adding overhead.

In case you've noticed something that it's not correctly being
disabled or it's introducing overhead, I'd glad to have a look at it.

Regards,
-- 
Rodrigo S. de Castro <rc...@im...>