Re: [lc-devel] Module Problems with 0.22 final AND vanilla 2.4.18

[Rodrigo S. de C. <rc...@im...>]

Hi Marc-Christian,

On Thu, Mar 21, 2002 at 10:01:36AM +0100, Marc-Christian Petersen wrote:
> root@codeman:/# depmod -ae
> depmod: *** Unresolved symbols in 
> /lib/modules/2.4.18/kernel/fs/ncpfs/ncpfs.o
> depmod:         flush_comp_cache
> depmod: *** Unresolved symbols in 
> /lib/modules/2.4.18/kernel/fs/smbfs/smbfs.o
> depmod:         flush_comp_cache
> 
> How can i get rid of this??

Thanks for the report. I forgot those filesystems could be built as
modules and didn't export that symbol. Check if the following patch
solves your problem. The fix will be in 0.23pre1 too.

> Hmm, 0.22pre6 has no problems but some oops'ses at runtime :-(((

Yes, one of the problems in 0.22pre6 was the lack of this
flush_comp_cache() to keep the compressed cache uptodate :-)

Regards,
-- 
Rodrigo S. de Castro <rc...@im...>

--- linuxcompressed/mm/comp_cache/Makefile.orig	Wed Mar 20 11:45:03 2002
+++ linuxcompressed/mm/comp_cache/Makefile	Thu Mar 21 08:30:26 2002
@@ -4,6 +4,8 @@
 
 O_TARGET := comp_cache.o
 
+export-objs := swapin.o
+
 obj-y    := main.o vswap.o free.o swapout.o swapin.o adaptivity.o aux.o proc.o WK4x4.o WKdm.o
 
 include $(TOPDIR)/Rules.make
--- linuxcompressed/mm/comp_cache/swapin.c.orig	Wed Mar 20 15:50:04 2002
+++ linuxcompressed/mm/comp_cache/swapin.c	Thu Mar 21 08:37:01 2002
@@ -1,7 +1,7 @@
 /*
  * linux/mm/comp_cache/swapin.c
  *
- * Time-stamp: <2002-03-20 15:50:04 rcastro>
+ * Time-stamp: <2002-03-21 08:37:01 rcastro>
  *  
  * Linux Virtual Memory Compressed Cache
  * - Swap In and Decompression Routines
@@ -13,6 +13,7 @@
 #include <linux/comp_cache.h>
 #include <linux/mm.h>
 #include <linux/pagemap.h>
+#include <linux/module.h>
 
 #include <asm/uaccess.h>
 #include <net/checksum.h>
@@ -29,6 +30,8 @@
 	return err;
 }
 
+EXPORT_SYMBOL(flush_comp_cache);
+
 int FASTCALL(flush_comp_cache(struct page *));
 int flush_comp_cache(struct page * page)
 {	
@@ -56,7 +59,6 @@
  out:	
 	return err;
 }
-
 
 extern void comp_cache_update_decomp_stats(unsigned short, stats_page_t *);