linuxcompressed-devel

[lc-devel] Module Problems with 0.22 final AND vanilla 2.4.18

[Marc-Christian P. <m....@gm...>]

Hi Rodrigo,

if i use vanilla 2.4.18 with final 0.22 compressed cache and i compile my=
=20
modules and install them the following occurs:


root@codeman:/# depmod -ae
depmod: *** Unresolved symbols in=20
/lib/modules/2.4.18/kernel/fs/ncpfs/ncpfs.o
depmod:         flush_comp_cache
depmod: *** Unresolved symbols in=20
/lib/modules/2.4.18/kernel/fs/smbfs/smbfs.o
depmod:         flush_comp_cache

How can i get rid of this??

Hmm, 0.22pre6 has no problems but some oops'ses at runtime :-(((


--=20
Kind regards
=09Marc-Christian Petersen

http://sourceforge.net/projects/wolk

PGP/GnuPG Key: 1024D/569DE2E3DB441A16
Fingerprint: 3469 0CF8 CA7E 0042 7824  080A 569D E2E3 DB44 1A16
Key available at wwwkeys.pgp.net. =A0 Encrypted e-mail preferred.

Re: [lc-devel] Module Problems with 0.22 final AND vanilla 2.4.18

[Rodrigo S. de C. <rc...@im...>]

Hi Marc-Christian,

On Thu, Mar 21, 2002 at 10:01:36AM +0100, Marc-Christian Petersen wrote:
> root@codeman:/# depmod -ae
> depmod: *** Unresolved symbols in 
> /lib/modules/2.4.18/kernel/fs/ncpfs/ncpfs.o
> depmod:         flush_comp_cache
> depmod: *** Unresolved symbols in 
> /lib/modules/2.4.18/kernel/fs/smbfs/smbfs.o
> depmod:         flush_comp_cache
> 
> How can i get rid of this??

Thanks for the report. I forgot those filesystems could be built as
modules and didn't export that symbol. Check if the following patch
solves your problem. The fix will be in 0.23pre1 too.

> Hmm, 0.22pre6 has no problems but some oops'ses at runtime :-(((

Yes, one of the problems in 0.22pre6 was the lack of this
flush_comp_cache() to keep the compressed cache uptodate :-)

Regards,
-- 
Rodrigo S. de Castro <rc...@im...>

--- linuxcompressed/mm/comp_cache/Makefile.orig	Wed Mar 20 11:45:03 2002
+++ linuxcompressed/mm/comp_cache/Makefile	Thu Mar 21 08:30:26 2002
@@ -4,6 +4,8 @@
 
 O_TARGET := comp_cache.o
 
+export-objs := swapin.o
+
 obj-y    := main.o vswap.o free.o swapout.o swapin.o adaptivity.o aux.o proc.o WK4x4.o WKdm.o
 
 include $(TOPDIR)/Rules.make
--- linuxcompressed/mm/comp_cache/swapin.c.orig	Wed Mar 20 15:50:04 2002
+++ linuxcompressed/mm/comp_cache/swapin.c	Thu Mar 21 08:37:01 2002
@@ -1,7 +1,7 @@
 /*
  * linux/mm/comp_cache/swapin.c
  *
- * Time-stamp: <2002-03-20 15:50:04 rcastro>
+ * Time-stamp: <2002-03-21 08:37:01 rcastro>
  *  
  * Linux Virtual Memory Compressed Cache
  * - Swap In and Decompression Routines
@@ -13,6 +13,7 @@
 #include <linux/comp_cache.h>
 #include <linux/mm.h>
 #include <linux/pagemap.h>
+#include <linux/module.h>
 
 #include <asm/uaccess.h>
 #include <net/checksum.h>
@@ -29,6 +30,8 @@
 	return err;
 }
 
+EXPORT_SYMBOL(flush_comp_cache);
+
 int FASTCALL(flush_comp_cache(struct page *));
 int flush_comp_cache(struct page * page)
 {	
@@ -56,7 +59,6 @@
  out:	
 	return err;
 }
-
 
 extern void comp_cache_update_decomp_stats(unsigned short, stats_page_t *);
 

Re: [lc-devel] Module Problems with 0.22 final AND vanilla 2.4.18

[Rodrigo S. de C. <rc...@im...>]

On Thu, Mar 21, 2002 at 08:44:01AM -0300, Rodrigo Souza de Castro wrote:
> On Thu, Mar 21, 2002 at 10:01:36AM +0100, Marc-Christian Petersen wrote:
> > root@codeman:/# depmod -ae
> > depmod: *** Unresolved symbols in 
> > /lib/modules/2.4.18/kernel/fs/ncpfs/ncpfs.o
> > depmod:         flush_comp_cache
> > depmod: *** Unresolved symbols in 
> > /lib/modules/2.4.18/kernel/fs/smbfs/smbfs.o
> > depmod:         flush_comp_cache
> > 
> > How can i get rid of this??
> 
> Thanks for the report. I forgot those filesystems could be built as
> modules and didn't export that symbol. Check if the following patch
> solves your problem. The fix will be in 0.23pre1 too.

That patch was for my pool, that already has some changes. Given that
you have 0.22, try the next one.

Regards,
-- 
Rodrigo S. de Castro <rc...@im...>

--- orig/mm/comp_cache/Makefile.orig	Thu Mar 21 08:48:10 2002
+++ orig/mm/comp_cache/Makefile	Thu Mar 21 08:48:31 2002
@@ -4,6 +4,8 @@
 
 O_TARGET := comp_cache.o
 
+export-objs := swapin.o
+
 obj-y    := main.o vswap.o free.o swapout.o swapin.o adaptivity.o aux.o proc.o WK4x4.o WKdm.o
 
 include $(TOPDIR)/Rules.make
--- orig/mm/comp_cache/swapin.c.orig	Thu Mar 21 08:48:06 2002
+++ orig/mm/comp_cache/swapin.c	Thu Mar 21 08:49:15 2002
@@ -1,7 +1,7 @@
 /*
  * linux/mm/comp_cache/swapin.c
  *
- * Time-stamp: <2002-03-14 16:41:47 rcastro>
+ * Time-stamp: <2002-03-21 08:49:15 rcastro>
  *  
  * Linux Virtual Memory Compressed Cache
  * - Swap In and Decompression Routines
@@ -13,6 +13,7 @@
 #include <linux/comp_cache.h>
 #include <linux/mm.h>
 #include <linux/pagemap.h>
+#include <linux/module.h>
 
 #include <asm/uaccess.h>
 #include <net/checksum.h>
@@ -28,6 +29,8 @@
 
 	return err;
 }
+
+EXPORT_SYMBOL(flush_comp_cache);
 
 int
 flush_comp_cache(struct address_space *mapping, unsigned long offset, struct page * page)

Re: [lc-devel] Module Problems with 0.22 final AND vanilla 2.4.18

[Marc-Christian P. <m....@gm...>]

On Donnerstag 21 M=E4rz 2002 12:57 Rodrigo Souza de Castro wrote:

Hi Rodrigo,

>That patch was for my pool, that already has some changes. Given that
>you have 0.22, try the next one.

root@codeman:/usr/src/linux-2.4.18# patch -p1 --dry-run <=20
patch-comp-cache-2.4.18-0.22-symexpfix=20
patch: **** Only garbage was found in the patch input.

?

--=20
Kind regards
=09Marc-Christian Petersen

http://sourceforge.net/projects/wolk

PGP/GnuPG Key: 1024D/569DE2E3DB441A16
Fingerprint: 3469 0CF8 CA7E 0042 7824  080A 569D E2E3 DB44 1A16
Key available at wwwkeys.pgp.net. =A0 Encrypted e-mail preferred.

Re: [lc-devel] Module Problems with 0.22 final AND vanilla 2.4.18

[Rodrigo S. de C. <rc...@im...>]

On Thu, Mar 21, 2002 at 02:00:54PM +0100, Marc-Christian Petersen wrote:
> On Donnerstag 21 März 2002 12:57 Rodrigo Souza de Castro wrote:
> >That patch was for my pool, that already has some changes. Given that
> >you have 0.22, try the next one.
> 
> root@codeman:/usr/src/linux-2.4.18# patch -p1 --dry-run < 
> patch-comp-cache-2.4.18-0.22-symexpfix 
> patch: **** Only garbage was found in the patch input.

Have you saved the patch and removed my message and also the
sourceforge message at the bottom of the email? I've just done that,
and it applied cleaned on a vanilla + 0.22 tree. 

Anyway, since it only changes comp cache files, it should not have any
error, even if you have other patches applied (likely to be your
case).

1. Save the email to a file, removing the crap (my message and sf
   note)

2. Apply it to your tree.

[rcastro@vinci:~/mestrado/kernel/orig]$ patch -p1 -i /tmp/patch
patching file mm/comp_cache/Makefile
patching file mm/comp_cache/swapin.c
[rcastro@vinci:~/mestrado/kernel/orig]$

Regards,
-- 
Rodrigo S. de Castro <rc...@im...>

Re: [lc-devel] Module Problems with 0.22 final AND vanilla 2.4.18

[Marc-Christian P. <m....@gm...>]

On Donnerstag 21 M=E4rz 2002 14:32 you wrote:

Hi Rodrigo,

> Have you saved the patch and removed my message and also the
> sourceforge message at the bottom of the email? I've just done that,
> and it applied cleaned on a vanilla + 0.22 tree.
you must be joking! SURE!! :-)

> 1. Save the email to a file, removing the crap (my message and sf
>    note)
exactly done so.

> [rcastro@vinci:~/mestrado/kernel/orig]$ patch -p1 -i /tmp/patch
> patching file mm/comp_cache/Makefile
> patching file mm/comp_cache/swapin.c
> [rcastro@vinci:~/mestrado/kernel/orig]$
very very curious :)

--=20
Kind regards
=09Marc-Christian Petersen

http://sourceforge.net/projects/wolk

PGP/GnuPG Key: 1024D/569DE2E3DB441A16
Fingerprint: 3469 0CF8 CA7E 0042 7824  080A 569D E2E3 DB44 1A16
Key available at wwwkeys.pgp.net. =A0 Encrypted e-mail preferred.