Re: [Linuxcoe-devel] [PATCH] patches for multiple-serial numbers SIM installs

[Bryan G. <Bry...@HP...>]

Daniel,

> I've attached some patches that I think might be fun to get into the LinuxCOE 
> repository.

These is great thinking, and expands our current SIM interoperability
in a way that doesn't compromise the current use case.

> coe_bootimage.in.patch changes the Serial Number field to accept a file, and 
> handles the upload. Each line in the updated file is read as a string and 
> interpreted as a serial number.
> 
> nph-coe_image.in.patch changes the rpm-based image creation to behave 
> correctly given an uploaded file instead of a single serial number
> 
> nph-debian_image.in.patch does the same thing for debian (patches for other 
> distros are in the works)

It may take us a few days to completely digest the changes suggested,
and ensure compatibility with current functions.  Besides our lead
coder is currently on vacation, and I would definitely like to
have him review these as well before implementation.

> LinuxCOE-SystemDesigner.conf.in.patch adds the AddType text/html .shtml and 
> AddOutputFilter INCLUDES .shtml directives because I think they should be in 
> there. I know it's a matter of preference, so I won't be overly disappointed 
> if this one doesn't make it in. :)

Heh, I have debated this issue over time, and as soon as I can do some
more distribution testing, will probably implement "just do it".

> tests.patch contains what I hope will be the first and the most crude 
> unit-test using the CGI::Test cpan module.

This is an excellent find and would have saved me many hours of
walking the WebUI looking for issues.  BTW, is there any chance
you might consider making this a somewhat self generated script,
in that it could use the SystemDesigner libraries to read the
various config files, and then create a script to ensure the
WebUI elements are present (and that the resulting image/profile/retrofit
script are as expected?

Have you created an sf.net user yet, so that we could add you
to the development team?

bryang