Re: [Linuxcoe-devel] Update on packaging

[Bryan G. <Bry...@HP...>]

Bruno,

Just committed the changes to address this issue (I hope, see diff
below).  A couple of goofs on my part, I moved from NA -> SKIP
without updating this script, and the echo was from previous debugging
attempts.  Sorry about that,

bryang

On Thu, Jan 31, 2008 at 06:29:39AM +0000, Cornec, Bruno (Linux Consultant) wrote:
> Hello,
> 
> Bruno Cornec said on Fri, Dec 21, 2007 at 12:28:16PM +0100:
> 
> > I think I found why my packages didn't work correctly during my recent
> > LinuxCOE Lab. It seems that now the scratch_monkey dir isn't created
> > when we use --without-APACHE, which isn't correct for the package now.
> 
> Thanks to Bryan and Lee hard work, I now have much more clean rpm.
> However, I have a last (for the moment) remaining issue:
> 
> # rpm -Uvh --force
> # /home/bruno/LinuxCOE/build/RPMS/noarch/linuxcoe-sd-base-4.1-1.mdv2007.0.noarch.rpm
> Pr?paration...              ########################################### [100%]
>    1:linuxcoe-sd-base       ########################################### [100%]
> LinuxCOE SystemDesigner integration tasks
>   creating link : /var/www/linuxcoe-sd/linuxcoe.rc
> Apache-specific integration tasks
>   creating link : /etc/httpd/conf.d/LinuxCOE-SystemDesigner.conf
> NOTE : Apache web server should now be restarted
> NOTE : for this modified configuration to take effect.
> /var/www/linuxcoe-sd/bin/post-actions: line 300: SKIP: command not found
> SKIP restart
> sudo-specific integration tasks
> Reloading httpd: [  OK  ]
> 
> So looking at the post-action script generated I found:
> 
>       # restart apache, for either install/uninstall cases
>         test -n "$VERBOSE" && {
>           echo "NOTE : Apache web server should now be restarted"
>           echo "NOTE : for this modified configuration to take effect."
>         }
>         if test "x${APACHE2CTL}" = "xNA" -o "x${APACHE2CTL}" = "xNONE"; then
>           if type apache2ctl >/dev/null 2>&1; then
>             apache2ctl restart
>           fi
>         else
>           ${APACHE2CTL} restart
>         fi
>         if test "x${APACHECTL}" = "xNA" -o "x${APACHECTL}" = "xNONE"; then
>           if type apachectl >/dev/null 2>&1; then
>             apachectl restart
>           fi
>         else
>           echo ${APACHECTL} restart
>         fi

RCS file: /cvsroot/linuxcoe/SystemDesigner/bin/post-actions.in,v
retrieving revision 1.20
diff -r1.20 post-actions.in
295c295
<         if test "x${APACHE2CTL}" = "xNA" -o "x${APACHE2CTL}" =
"xNONE"; then
---
>         if test "x${APACHE2CTL}" = "xSKIP" -o "x${APACHE2CTL}" =
>         "xNONE"; then
302c302
<         if test "x${APACHECTL}" = "xNA" -o "x${APACHECTL}" = "xNONE";
then
---
>         if test "x${APACHECTL}" = "xSKIP" -o "x${APACHECTL}" =
>         "xNONE"; then
307c307
<           echo ${APACHECTL} restart 
---
>           ${APACHECTL} restart 
> 
> So I think there is a mismatch between the echo for ${APACHECTL} and
> lack of echo for ${APACHE2CTL} which seems to cause the error message.
> However, I don't know why we would want to echo SKIP restart ;-)

The SKIP value comes from the --without-APACHECTL, fwiw.

bryang