Re: [PATCH v2 3/4] firewire: core: Prevent device_find_child() from modifying caller's match data
Brought to you by:
aeb,
bencollins
From: Takashi S. <o-t...@sa...> - 2024-08-21 14:29:37
|
Hi, On Thu, Aug 15, 2024 at 10:58:04PM +0800, Zijun Hu wrote: > From: Zijun Hu <qui...@qu...> > > To prepare for constifying the following old driver core API: > > struct device *device_find_child(struct device *dev, void *data, > int (*match)(struct device *dev, void *data)); > to new: > struct device *device_find_child(struct device *dev, const void *data, > int (*match)(struct device *dev, const void *data)); > > The new API does not allow its match function (*match)() to modify > caller's match data @*data, but lookup_existing_device() as the old > API's match function indeed modifies relevant match data, so it is not > suitable for the new API any more, fixed by implementing a equivalent > fw_device_find_child() instead of the old API usage. > > Signed-off-by: Zijun Hu <qui...@qu...> > --- > drivers/firewire/core-device.c | 37 +++++++++++++++++++++++++++++++++++-- > 1 file changed, 35 insertions(+), 2 deletions(-) Please drop this patch from your series since I applied another patch[1] to for-next branch. [1] https://lore.kernel.org/r/202...@sa... Thanks Takashi Sakamoto |