Re: [PATCH 17/17] firewire: ohci: use guard macro to serialize operations for isochronous contexts
Brought to you by:
aeb,
bencollins
From: Takashi S. <o-t...@sa...> - 2024-08-05 08:34:01
|
On Mon, Aug 05, 2024 at 07:33:01AM +0800, kernel test robot wrote: > url: https://github.com/intel-lab-lkp/linux/commits/Takashi-Sakamoto/firewire-core-use-guard-macro-to-maintain-static-packet-data-for-phy-configuration/20240804-210645 > base: https://git.kernel.org/pub/scm/linux/kernel/git/ieee1394/linux1394.git for-next > patch link: https://lore.kernel.org/r/20240804130225.243496-18-o-takashi%40sakamocchi.jp > patch subject: [PATCH 17/17] firewire: ohci: use guard macro to serialize operations for isochronous contexts > config: arm64-randconfig-003-20240805 (https://download.01.org/0day-ci/archive/20240805/202...@in.../config) > compiler: clang version 17.0.6 (https://github.com/llvm/llvm-project 6009708b4367171ccdbf4b5905cb6a803753fe18) > reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240805/202...@in.../reproduce) > > If you fix the issue in a separate patch/commit (i.e. not just a new version of > the same patch/commit), kindly add following tags > | Reported-by: kernel test robot <lk...@in...> > | Closes: https://lore.kernel.org/oe-kbuild-all/202...@in.../ > > All errors (new ones prefixed by >>): > > >> drivers/firewire/ohci.c:3138:2: error: expected expression > 3138 | guard(spinlock_irq)(&ohci->lock); > | ^ > include/linux/cleanup.h:167:2: note: expanded from macro 'guard' > 167 | CLASS(_name, __UNIQUE_ID(guard)) > | ^ > include/linux/cleanup.h:122:2: note: expanded from macro 'CLASS' > 122 | class_##_name##_t var __cleanup(class_##_name##_destructor) = \ > | ^ > <scratch space>:133:1: note: expanded from here > 133 | class_spinlock_irq_t > | ^ > 1 error generated. The macro expands a declaration, while the line just after the label should be still any statement in C11. I'll post take 2 patchset. Thanks Takashi Sakamoto |