Re: [PATCH 0/4] firewire: ohci: add helper functions for data format specific to 1394 OHCI AT/IT DMA

[Takashi S. <o-t...@sa...>]

On Fri, Aug 02, 2024 at 09:36:02AM +0900, Takashi Sakamoto wrote:
> Hi,
> 
> In 1394 OHCI specification, the data formats of AT/IT DMA are specific
> and different from packert format of IEEE 1394 specification. Current
> implementation includes some ad-hoc lines to construct the data, while
> it is not so easy to read and understand.
> 
> This patchset includes some helper functions to serialize and
> deserialize the data. These helper functions are tested by KUnit, and
> replace the ad-hoc implementations.
> 
> Takashi Sakamoto (4):
>   firewire: ohci: add static inline functions to serialize/deserialize
>     data of AT DMA
>   firewire: ohci: use static inline functions to serialize data of AT
>     DMA
>   firewire: ohci: add static inline functions to serialize/deserialize
>     data of IT DMA
>   firewire: ohci: use static inline functions to serialize data of IT
>     DMA
> 
>  drivers/firewire/ohci-serdes-test.c |  66 +++++++++
>  drivers/firewire/ohci.c             |  66 ++++-----
>  drivers/firewire/ohci.h             | 199 ++++++++++++++++++++++++++++
>  3 files changed, 299 insertions(+), 32 deletions(-)

Applied to for-next branch.


Regards

Takashi Sakamoto