Re: [PATCH 00/11] firewire: add tracepoints events for self ID sequence
Brought to you by:
aeb,
bencollins
From: Takashi S. <o-t...@sa...> - 2024-06-06 22:56:11
|
On Thu, Jun 06, 2024 at 08:51:44AM +0900, Takashi Sakamoto wrote: > Hi, > > In core function, the enumeration of self ID sequences is the first step > to build bus topology for the current generation. Currently, 1394 OHCI > driver has a module option to dump the content of self ID sequence, while > it is implemented by printk. My recent work is going to replace such > logging with tracepoints events, and this series of changes is for the > self ID sequence. > > The content of self ID sequence is delivered by a kind of phy packet, > and its serialization and deserialization codes exist in both core function > and 1394 OHCI driver. They include some redundancies, and the series of > changes includes some inline helper functions to replace them. > > In the series of changes, some KUnit tests are added to check behaviour > of the enumeration and the helper functions. > > Takashi Sakamoto (11): > firewire: core: add enumerator of self ID sequences and its KUnit test > firewire: core: add helper function to handle port status from self ID > sequence and its KUnit test > firewire: core: minor code refactoring for topology builder > firewire: ohci: minor code refactoring for self ID logging > firewire: core: use helper functions for self ID sequence > firewire: ohci: use helper functions for self ID sequence > firewire: core: add common inline functions to serialize/deserialize > self ID packet > firewire: core: use helper inline functions to deserialize self ID > packet > firewire: ohci: use helper inline functions to serialize/deserialize > self ID packet > firewire: core: arrangement header inclusion for tracepoints events > firewire: core: add tracepoints event for self_id_sequence > > drivers/firewire/.kunitconfig | 1 + > drivers/firewire/Kconfig | 15 ++ > drivers/firewire/Makefile | 1 + > drivers/firewire/core-topology.c | 219 ++++++--------- > drivers/firewire/core-trace.c | 18 ++ > drivers/firewire/core-transaction.c | 2 +- > drivers/firewire/ohci.c | 148 ++++++---- > drivers/firewire/packet-header-definitions.h | 2 + > drivers/firewire/packet-serdes-test.c | 255 ++++++++++++++++++ > drivers/firewire/phy-packet-definitions.h | 247 +++++++++++++++++ > .../firewire/self-id-sequence-helper-test.c | 152 +++++++++++ > include/trace/events/firewire.h | 61 ++++- > 12 files changed, 935 insertions(+), 186 deletions(-) > create mode 100644 drivers/firewire/phy-packet-definitions.h > create mode 100644 drivers/firewire/self-id-sequence-helper-test.c Applied to for-next branch. Regards Takashi Sakamoto |