Re: [PATCH] Revert "PCI: Mark LSI FW643 to avoid bus reset"
Brought to you by:
aeb,
bencollins
From: Takashi S. <o-t...@sa...> - 2024-03-29 08:04:19
|
On Thu, Mar 28, 2024 at 04:23:02PM -0500, Bjorn Helgaas wrote: > From: Bjorn Helgaas <bhe...@go...> > > This reverts commit 29a43dc130ce65d365a8ea9e1cc4bc51005a353e. > > 29a43dc130ce ("PCI: Mark LSI FW643 to avoid bus reset") by Edmund was based > on the assumption that the LSI / Agere FW643 has a defect such that it > can't recover after a Secondary Bus Reset (SBR). > > But Takashi Sakamoto reported that SBR works fine on this same FW643 device > in an AMD Ryzen 5 2400G system, so apparently there is some other aspect of > Edmund's system that accounts for the issue. > > The down side of 29a43dc130ce is that when the FW643 is assigned to a VM, > avoiding the SBR means we leak data out of the VM. > > Revert 29a43dc130ce until we figure out a better solution. In the > meantime, we can use the sysfs "reset_method" interface to restrict the > available reset methods. > > Fixes: 29a43dc130ce ("PCI: Mark LSI FW643 to avoid bus reset") > Reported-by: Takashi Sakamoto <o-t...@sa...> > Link: https://lore.kernel.org/r/202...@sa... > Signed-off-by: Bjorn Helgaas <bhe...@go...> > --- > drivers/pci/quirks.c | 8 -------- > 1 file changed, 8 deletions(-) Reviewed-by: Takashi Sakamoto <o-t...@sa...> Thank you for the revert patch, and I apologize for the delay in catching up with the change. Please feel free to add me or the linux1394-devel list to CC of these kind of changes. Thanks Takashi Sakamoto |