Re: Hard crash when loading firewire-ohci

[Takashi S. <o-t...@sa...>]

Hi,

The change for 1394 OHCI driver, aimed at suppressing the unexpected
system reboot in AMD Ryzen machine[1], has been merged into Linux kernel
v6.7[2]. It has also been applied to the following releases of stable and
longterm kernels.

* 6.6.11[3]
* 6.1.72[4]
* 5.15.147[5]
* 5.10.208[6]
* 5.4.267[7]
* 4.19.305[8]
* 4.14.336[9]

Once the downstream distribution project provides the corresponding kernel
packages, you should no longer encounter the unexpected system reboot.

Note that the following combination of hardware is not necessarily suitable,
depending on your use case:

* Any type of AMD Ryzen machine
* 1394 OHCI hardware consists of:
    * Asmedia ASM1083/1085
    * VIA VT6306/6307/6308

When working with time-aware protocol, such as audio sample processing, it
is advisable to avoid the combination. The change accompanies a functional
limitation that the software stack does not provides precise hardware time
in this case.

If you choose to continue using AMD Ryzen machine, the recommendation is
to replace the 1394 OHCI hardware with another one. Conversely, if you
choose to continue using the 1394 OHCI hardware, the recommendation is to
use the machine provided by vendors other than AMD.

Thanks for your report and long patience.

[1] https://git.kernel.org/torvalds/linux/c/ac9184fbb847
[2] https://lore.kernel.org/lkml/CAHk-=wid...@ma.../
[3] https://lore.kernel.org/lkml/2024011058-sheep-thrower-d2f8@gregkh/
[4] https://lore.kernel.org/lkml/2024011052-unsightly-bronze-e628@gregkh/
[5] https://lore.kernel.org/lkml/2024011541-defective-scuff-c55e@gregkh/
[6] https://lore.kernel.org/lkml/2024011532-lustiness-hybrid-fc72@gregkh/
[7] https://lore.kernel.org/lkml/2024011519-mating-tag-1f62@gregkh/
[8] https://lore.kernel.org/lkml/2024011508-shakiness-resonant-f15e@gregkh/
[9] https://lore.kernel.org/lkml/2024011046-ecology-tiptoeing-ce50@gregkh/

On Tue, Dec 12, 2023 at 01:13:40AM +0100, Tobias Gruetzmacher wrote:
> [Resend because I wasn't subcribed before]
> 
> Hi,
> 
> in recent kernels (noticed with Debian kernel 6.5) I get a hard crash
> when the firewire-ohci module is loaded.
> 
> I could bisect this issue to commit
> 
> dcadfd7f7c74ef9ee415e072a19bdf6c085159eb is the first bad commit
> commit dcadfd7f7c74ef9ee415e072a19bdf6c085159eb
> Author: Takashi Sakamoto <o-t...@sa...>
> Date:   Tue May 30 08:12:40 2023 +0900
> 
>     firewire: core: use union for callback of transaction completion
> 
> But I'm not sure how to continue debugging from here, since I don't get
> any output after
> 
> [Dec10 19:17] firewire_ohci 0000:0b:00.0: enabling device (0000 -> 0003)
> [  +0.075791] firewire_ohci 0000:0b:00.0: added OHCI v1.0 device as card 0, 4 IR + 8 IT contexts, quirks 0x11
> 
> My hardware is:
> 
> 0b:00.0 FireWire (IEEE 1394): VIA Technologies, Inc. VT6306/7/8 [Fire II(M)] IEEE 1394 OHCI Controller (rev c0) (prog-if 10 [OHCI])
>         Subsystem: VIA Technologies, Inc. VT6306/7/8 [Fire II(M)] IEEE 1394 OHCI Controller
>         Flags: medium devsel, IRQ 255
>         Memory at fc800000 (32-bit, non-prefetchable) [disabled] [size=2K]
>         I/O ports at d000 [disabled] [size=128]
>         Capabilities: [50] Power Management version 2
>         Kernel modules: firewire_ohci
> 
> There are currently no devices connected.
> 
> I could work around the issue by blacklisting the module, since I
> currently don't use the FireWire hardware (but there are still some DV
> tapes waiting to be transferred...)
> 
> Regards, Tobias


Thanks

Takashi Sakamoto