Re: [PATCH] Fix missing sysfs vendor/model entries for some devices
Brought to you by:
aeb,
bencollins
From: Adam G. <ad...@po...> - 2023-11-28 09:27:30
|
On Mon, Nov 27, 2023 at 07:40:03PM +0900, Takashi Sakamoto wrote: > Thanks for the patch. Indeed, for the legacy layout of Configuration ROM, > current implementation of core functionality does not pick up enough > information from the vendor directory. I think you already know the similar > case in the issue filed in systemd project. Thanks for your reply and for your work maintaining the FireWire subsystem. > The patch format is not compliant to Linux kernel development, while I > would evaluate it. Should I submit the patch again in canonical patch format[1]? > However, I need more actual examples. Would I ask you > to provide images of Configuration ROM retrieved by your test devices? > I think you own Sony DCR-TRV120 and Panasonic AG-DV1DC. I maintain > collections of Configuration ROM[2] and it is preferable to receive merge > request in github.com service. I've sent a merge request with the Configuration ROM images. [1] https://docs.kernel.org/process/submitting-patches.html#the-canonical-patch-format -- Adam |