Re: raw1394_request user/kernel space size differences
Brought to you by:
aeb,
bencollins
From: Andreas B. <and...@mu...> - 2000-06-02 17:09:40
|
On Fri, Jun 02, 2000 at 01:16:11AM +0200, Andreas Bombe wrote: > On Mon, May 29, 2000 at 05:45:35PM -0400, Ben Collins wrote: > > > Ok, I tested this and it worked. So I took it one step further. Attached > > > are two patches. One for linux1394 CVS which defines a kptr_t just like > > > you did for libraw1394. The other is for libraw1394 to sync the raw1394.h > > > from the kernel source. > > > > Guess attaching the patches would actually help. > > Using explicit width types for everything seems like a good idea. But > we can also just forget the environment and always use __u64 types for > the pointer fields. Writing a 64 bit field in a 32 bit environment > will clear the upper 32 and write the lower 32 bits, just like your > SET_CAST_PTR macro --- just cleaner and without endianness problems > (looking at your macro I can see Sparc is run big endian). I implemented that now and put it in CVS. This time you need to update both kernel and libraw1394. The compiler warnings (cast to/from pointer from/to int of different size) however annoy me. I'll see what I can do about that... -- Andreas E. Bombe <and...@mu...> DSA key 0x04880A44 http://home.pages.de/~andreas.bombe/ http://linux1394.sourceforge.net/ |