Re: [PATCH 0/9] firewire: ohci: adoption of device managed resource
Brought to you by:
aeb,
bencollins
From: Takashi S. <o-t...@sa...> - 2023-06-05 22:56:42
|
On Sun, Jun 04, 2023 at 02:44:42PM +0900, Takashi Sakamoto wrote: > Hi, > > Linux FireWire subsystem includes a driver (firewire-ohci) for 1394 OHCI > controller. The code of driver is mostly written at the time when device > managed resource (devres) was not widely used. Nowadays the usage of > devres is standard when writing drivers. The series is an adoption of > devres for firewire-ohci. > > I note that MSI-related operation is left as is. The hardware vendors > forms their products of extension card with 1394 OHCI controller > connected to PCIe bus by several ways. If chip of 1394 OHCI controller has > PCIe interface (e.g. VIA VT6315, LSI FW643), it is just connected to PCIe > bus. If the chip has PCI interface only, it is connected to PCIe bus via > PCI/PCIe bridge chip (e.g. VIA VT6307 + asmedia ASM1083). There is some > chip of 1394 OHCI controller integrated with the bus bridge (e.g. TI > XIO2213, XIO2221). The MSI-related operation should cover the above > forms as well as module option, while it is still unclear that the > operation from pci device driver to the bus bridge. > > Takashi Sakamoto (9): > firewire: ohci: use devres for memory object of ohci structure > firewire: ohci: use devres for PCI-related resources > firewire: ohci: use devres for MMIO region mapping > firewire: ohci: use devres for misc DMA buffer > firewire: ohci: use devres for requested IRQ > firewire: ohci: use devres for list of isochronous contexts > firewire: ohci: use devres for IT, IR, AT/receive, and AT/request > contexts > firewire: ohci: use devres for content of configuration ROM > firewire: ohci: release buffer for AR req/resp contexts when managed > resource is released > > drivers/firewire/ohci.c | 174 +++++++++++++++------------------------- > 1 file changed, 63 insertions(+), 111 deletions(-) Applied to for-next branch. Regards Takashi Sakamoto |