Re: [PATCH] eth1394: dev file [Report about error: unknown bus]
Brought to you by:
aeb,
bencollins
From: Randy.Dunlap <rdd...@os...> - 2004-10-21 04:14:45
|
Paul Blazejowski wrote: > On Wed, 2004-10-20 at 16:26 -0700, Randy.Dunlap wrote: > >>Kay Sievers wrote: >> >>>On Wed, Oct 20, 2004 at 01:44:58PM -0400, Paul Blazejowski wrote: >>> >>> >>>>On Wed, 2004-10-20 at 15:17 +0200, Kay Sievers wrote: >>>> >>>> >>>> >>>>>>'/class/net/eth1' properly (no device symlink) or the sysfs-support of >>>>>>your device's driver needs to be fixed >>>>> >>>>>What driver creates the eth1 device? It needs to crete the "device" symlink >>>>>and the maintainer should know. >>>> >>>>eth1 Link encap:UNSPEC HWaddr >>>>8A-1C-C7-FF-FF-00-20-ED-00-00-00-00-00-00-00-00 >>>> >>>>is created by the eth1394 driver. >>> >>> >>>[CC: to the 1394 devel-list] >>> >>>The eth1394.c driver needs to create the symlinks in its sysfs >>>representation to get support for modern userspace integration. >>>Most networkd drivers use: >>> >>> SET_NETDEV_DEV(dev, &pdev->dev); >>> >>>to do that. >> >>Paul, >>Can you test this patch, please? >> >>Thanks, > > > Randy applied the patch to kernel 2.6.9 and now eth1394 creates symlink > under /sys/class/net/eth2 > > lrwxrwxrwx 1 root root 0 2004-10-20 23:58 device > -> ../../../devices/pci0000:00/0000:00:0d.0/fw-host0/ > > Thank you, > > Paul So is this correct? Does it do the right thing? -- ~Randy |