Thread: pcilynx: aux_poll question
Brought to you by:
aeb,
bencollins
From: Manfred S. <man...@co...> - 2000-04-23 10:17:35
|
Linus made a last minute SMP change: f_op->poll now runs without lock_kernel(). I currently try to verify all _poll functions, and don't understand aux_poll: what's the purpose of md->aux_intr_last_seen++; A normal "++" isn't SMP safe, so either lock_kernel() should be added, or aux_intr_last_seen could be converted to an atomic_t variable. -- Manfred |
From: Andreas B. <and...@mu...> - 2000-04-25 03:45:53
|
On Sun, Apr 23, 2000 at 12:10:55PM +0200, Manfred Spraul wrote: > Linus made a last minute SMP change: > > f_op->poll now runs without lock_kernel(). > > I currently try to verify all _poll functions, and don't understand > aux_poll: what's the purpose of > > md->aux_intr_last_seen++; Makes poll return POLLPRI one time for each interrupt that was received from some special channel on the PCILynx (even if the last poll lies a few interrupts in the past). It's not part of IEEE 1394 functionality, it's just some special features of the PCILynx that I need to support. > A normal "++" isn't SMP safe, so either lock_kernel() should be added, > or aux_intr_last_seen could be converted to an atomic_t variable. Thanks, will be done. -- Andreas E. Bombe <and...@mu...> DSA key 0x04880A44 http://home.pages.de/~andreas.bombe/ http://linux1394.sourceforge.net/ |