Thread: [PATCH] firewire: ohci: deprecate debug parameter
Brought to you by:
aeb,
bencollins
From: Takashi S. <o-t...@sa...> - 2024-09-03 10:15:12
|
Many tracepoints events have been added to 6.10 and 6.11 kernels. They are available as an alternative of debug parameter in firewire-ohci module. The logging messages enabled by the parameter require some cumbersomes in a point of maintenance; e.g. the code to decode transaction frame. This commit adds deprecation text to conduct users to them.. Signed-off-by: Takashi Sakamoto <o-t...@sa...> --- drivers/firewire/ohci.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/firewire/ohci.c b/drivers/firewire/ohci.c index a3a37955b174..e662dc30c21f 100644 --- a/drivers/firewire/ohci.c +++ b/drivers/firewire/ohci.c @@ -396,7 +396,7 @@ MODULE_PARM_DESC(quirks, "Chip quirks (default = 0" static int param_debug; module_param_named(debug, param_debug, int, 0644); -MODULE_PARM_DESC(debug, "Verbose logging (default = 0" +MODULE_PARM_DESC(debug, "Verbose logging, deprecated in v6.11 kernel or later. (default = 0" ", AT/AR events = " __stringify(OHCI_PARAM_DEBUG_AT_AR) ", self-IDs = " __stringify(OHCI_PARAM_DEBUG_SELFIDS) ", IRQs = " __stringify(OHCI_PARAM_DEBUG_IRQS) @@ -2197,6 +2197,11 @@ static irqreturn_t irq_handler(int irq, void *data) if (!event || !~event) return IRQ_NONE; + if (unlikely(param_debug > 0)) { + dev_notice_ratelimited(ohci->card.device, + "The debug parameter is superceded by tracepoints events, and deprecated."); + } + /* * busReset and postedWriteErr events must not be cleared yet * (OHCI 1.1 clauses 7.2.3.2 and 13.2.8.1) -- 2.43.0 |
From: Takashi S. <o-t...@sa...> - 2024-09-04 10:15:18
|
On Tue, Sep 03, 2024 at 07:14:55PM +0900, Takashi Sakamoto wrote: > Many tracepoints events have been added to 6.10 and 6.11 kernels. They are > available as an alternative of debug parameter in firewire-ohci module. > > The logging messages enabled by the parameter require some cumbersomes in > a point of maintenance; e.g. the code to decode transaction frame. > > This commit adds deprecation text to conduct users to them.. > > Signed-off-by: Takashi Sakamoto <o-t...@sa...> > --- > drivers/firewire/ohci.c | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) Applied to for-next branch. Regards Takashi Sakamoto |