#15 Doesn't realize when connection is lost

[Scorpyn]

If one of the servers goes down, the client doesn't realize that until it tries to communicate with the control server. It still keeps trying to send data to the data server, without realizing that it's not there anymore.

If a client has lost the connection, the data server will keep sending data to that client, not realizing that it's gone.

[Scorpyn]

Logged In: YES
user_id=1576176
Originator: YES

Also, if the client disconnects "properly" (meaning that the control server notices that it's gone), the data server will still not realize that it's gone.

[Gabriele Dini Ciacci]

Logged In: YES
user_id=386114
Originator: NO

Should be fixed in 301, since I implemented disconnection properly.
Leaving open because it still need testing.

[Benjamin Peter]

Logged In: YES
user_id=1101616
Originator: NO

I tested rev. 301

Controlserver recognizes a dataserver disconnect but propagating
client disco to dataserver is missing
data server disco to client is missing

good work, keep on.

[Scorpyn]

Logged In: YES
user_id=1576176
Originator: YES

tested rev. 307

When closing the client, the dataserver gets a flood of the following 2 lines :

[<--] : Incoming data from a control server.
NetworkErrorException: Unknown packet identifier received.

When closing the control server, neither the data server nor the client seems to realize it.

When closing the data server, the control server realizes that it's been closed, but the client still keeps trying to send data. The client is spitting out some "I think we lost connection" messages though :

Error reciveing data from the server
Error receiving data from server
NetworkErrorException: Error reciveing data from the server, connection closed?

[Gabriele Dini Ciacci]

Logged In: YES
user_id=386114
Originator: NO

>When closing the client, the dataserver gets a flood of the following 2
>lines :
>[<--] : Incoming data from a control server.
>NetworkErrorException: Unknown packet identifier received.

rev 308 should fix this. Please test (I tested here and works)

>When closing the control server, neither the data server nor the client
>seems to realize it.

This will go in next round of fixes, it not too complex to manage.

>When closing the data server, the control server realizes that it's been
>closed, but the client still keeps trying to send data.

This is "hard" it's the reason why i have to move the client from event driven to select() driven. This happens because normally all messages are originated from the client, and server only responds, with the client knowing it's waiting for an answer. In this case the client is not waiting for an answer!! Because the closure of the dataserver originated from itself.
The controlserver can receive an unexpected command, the client as it is designed (very limited) can't

Will see when time is available to move to select(), this is on TODO by a lot of time (i hoped for a volunteer.. beeing an "easy" work)

[Scorpyn]

Logged In: YES
user_id=1576176
Originator: YES

>>When closing the client, the dataserver gets a flood of the following 2
>>lines :
>>[<--] : Incoming data from a control server.
>>NetworkErrorException: Unknown packet identifier received.
>
>rev 308 should fix this. Please test (I tested here and works)

Fix confirmed, it appears to be working properly here too.