Re: [Linux-NTFS-cvs] CVS: ntfsprogs/ntfsprogs ntfsinfo.c, 1.143, 1.144

[Yura P. <pak...@gm...>]

On Sun, 13 Aug 2006 at 21:02 +0200, Szakacsits Szabolcs wrote:
> Changes by: szaka
> 
> Update of /cvs/linux-ntfs/ntfsprogs/ntfsprogs
> In directory delta357.server4you.de:/tmp/cvs-serv8559
> 
> Modified Files:
> 	ntfsinfo.c 
> Log Message:
> ntfs_dump_flags(): dump FILE_ATTR_DIRECTORY
> 
> 
> Index: ntfsinfo.c
> ===================================================================
> RCS file: /cvs/linux-ntfs/ntfsprogs/ntfsprogs/ntfsinfo.c,v
> retrieving revision 1.143
> retrieving revision 1.144
> diff -u -p -r1.143 -r1.144
> --- ntfsinfo.c	13 Aug 2006 18:59:56 -0000	1.143
> +++ ntfsinfo.c	13 Aug 2006 19:02:30 -0000	1.144
> @@ -463,6 +463,10 @@ static void ntfs_dump_flags(const char *
>  		printf(" SYSTEM");
>  		flags &= ~FILE_ATTR_SYSTEM;
>  	}
> +	if (flags & FILE_ATTR_DIRECTORY) {
> +		printf(" DIRECTORY");
> +		flags &= ~FILE_ATTR_DIRECTORY;
> +	}
>  	if (flags & FILE_ATTR_ARCHIVE) {
>  		printf(" ARCHIVE");
>  		flags &= ~FILE_ATTR_ARCHIVE;

Wrong. Please read comments more careful:

        FILE_ATTR_DIRECTORY             = const_cpu_to_le32(0x00000010),
        /* FILE_ATTR_DIRECTORY is not considered valid in NT. It is reserved
           for the DOS SUBDIRECTORY flag. */

It should be unknown flag in case we will encounter it.

-- 
Best regards,
        Yura