Re: [Linux-NTFS-cvs] CVS: ntfsprogs/ntfsprogs ntfsmount.c,1.61,1.62

[Yura P. <pak...@ip...>]

Hi Szaka,

On Thu, 2005-11-24 at 16:47 +0100, Szakacsits Szabolcs wrote:
> On Thu, 24 Nov 2005, Yura Pakhuchiy wrote:
> 
> > +	/* Mark information about free MFT record and clusters outdate. */
> > +	ctx->state |= (NF_FreeClustersOutdate | NF_FreeMFTOutdate);
>     ...
> > +	/* Mark information about free MFT record and clusters outdate. */
> > +	ctx->state |= (NF_FreeClustersOutdate | NF_FreeMFTOutdate);
>     ...
> > +	/* Mark information about free MFT record and clusters outdate. */
> > +	ctx->state |= (NF_FreeClustersOutdate | NF_FreeMFTOutdate);
> 
>     ... many time exactly the same ...
> 
> Why not, for example
> 
>   inline void ntfs_fuse_outdate_state(ntfs_fuse_context_t *ctx)
>   {
> 	/* Mark information about free MFT record and clusters outdate. */
> 	ctx->state |= (NF_FreeClustersOutdate | NF_FreeMFTOutdate);
>   }
> 
>   ntfs_fuse_outdate_state(ctx);
>   ...
>   ntfs_fuse_outdate_state(ctx);
>   ...
> 
> Less code, easier to read, maintain, etc.

Thanks, good idea, I will fix.

-- 
Best regards,
        Yura