Re: [Linux-NTFS-cvs] CVS: ntfsprogs/ntfsprogs ntfsmount.c,1.61,1.62

[Szakacsits S. <sz...@si...>]

Hi Yura,

On Thu, 24 Nov 2005, Yura Pakhuchiy wrote:

> +	/* Mark information about free MFT record and clusters outdate. */
> +	ctx->state |= (NF_FreeClustersOutdate | NF_FreeMFTOutdate);
    ...
> +	/* Mark information about free MFT record and clusters outdate. */
> +	ctx->state |= (NF_FreeClustersOutdate | NF_FreeMFTOutdate);
    ...
> +	/* Mark information about free MFT record and clusters outdate. */
> +	ctx->state |= (NF_FreeClustersOutdate | NF_FreeMFTOutdate);

    ... many time exactly the same ...

Why not, for example

  inline void ntfs_fuse_outdate_state(ntfs_fuse_context_t *ctx)
  {
	/* Mark information about free MFT record and clusters outdate. */
	ctx->state |= (NF_FreeClustersOutdate | NF_FreeMFTOutdate);
  }

  ntfs_fuse_outdate_state(ctx);
  ...
  ntfs_fuse_outdate_state(ctx);
  ...

Less code, easier to read, maintain, etc.

BTW, this is a general comment, I've seen similar copy-pastes 
several times.

	Szaka