|
From: Anton A. <ai...@ca...> - 2004-03-24 13:58:45
|
On Wed, 2004-03-24 at 13:30, Szakacsits Szabolcs wrote: > On Tue, 23 Mar 2004, Anton Altaparmakov wrote: > I see you made the changes but I think it could have been simpler by > just using the similar interface, e.g. ntfs_device_geometry_get(), what > HDIO_GETGEO uses. Now basicaly the same code is copy-pasted into three > functions and only the return statement is different. It's more trouble > to maintain and more trouble to use them. Ah. I did have that coded but I changed it before committing it after reading the latest TestDisk release notes from which I gathered that at least FreeBSD uses separate ioctls to get each value so I decided to maek separate calls, too. Otherwise we would need to test each of the results for success even if the function was successful or alternatively we would alsways have to fail the function even if we can actually supply some (but not all) of the values automatically. Do you still think it should be a single ntfs_device_geometry_get() function? If yes then I would be willing to switch to that again - shame I didn't checkin the code before changing it as I will need to redo it from scratch... )-: > I have a request also, please make a source snapshot (last one was a week > ago). Done. > BTW, do we still need the ntfsprogs-devel tree? As I've seen, only I used > it, it was just extra work for you to maintain (thanks!) but I don't need > it anymore. Now it's also just extra work for me. So if nobody really > needs it we could just delete it? If there is need in the future by > somebody then we could still recreate it. I was only keeping it for you and am very happy to get rid of it. (-: <clicketyclick> It's now gone! (-: Best regards, Anton -- Anton Altaparmakov <aia21 at cam.ac.uk> (replace at with @) Unix Support, Computing Service, University of Cambridge, CB2 3QH, UK Linux NTFS maintainer / IRC: #ntfs on irc.freenode.net WWW: http://linux-ntfs.sf.net/ & http://www-stu.christs.cam.ac.uk/~aia21/ |
